Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency typesentry #1535

Closed
st-pasha opened this issue Jan 12, 2019 · 4 comments · Fixed by #2361
Closed

Remove dependency typesentry #1535

st-pasha opened this issue Jan 12, 2019 · 4 comments · Fixed by #2361
Assignees
@st-pasha
Labels
refactor Internal code changes, clean-ups or reorganizations that are not externally visible
Milestone
Release 0.11.0

Comments

@st-pasha
Copy link
Contributor

Module typesentry helps to check types in python. However, since we're slowly moving the majority of the code to C++, at this point we barely use that module at all. Removing it will make installation slightly easier, and reduce the startup overhead.
@st-pasha st-pasha added the refactor Internal code changes, clean-ups or reorganizations that are not externally visible label Jan 12, 2019
@st-pasha st-pasha self-assigned this Jan 12, 2019
@st-pasha st-pasha added this to the Release 0.9.0 milestone Jan 12, 2019
@st-pasha st-pasha removed this from the Release 0.10.0 milestone Nov 7, 2019
@igor-susic
Copy link

Hi @st-pasha, I started using datatable and really like it, better than pandas at least for me. Looking to help you guys, I feel this one would be ok to start contributing, is it ok by you guys?

@st-pasha
Copy link
Contributor Author

st-pasha commented Dec 5, 2019

@igor-susic Absolutely, go for it.

@st-pasha
Copy link
Contributor Author

st-pasha commented Jan 4, 2020

@igor-susic Hi Igor, I wonder if you're still interested in doing this? If not, that's perfectly fine -- just let us know so that someone else can pick up the task.

@st-pasha st-pasha mentioned this issue Jan 4, 2020
Closed
27 tasks
@igor-susic
Copy link

@st-pasha Yes, I'm still on it. Sorry, I was on vacation these holidays, otherwise, I would let you know sooner.

@st-pasha st-pasha added this to the Release 0.11.0 milestone Feb 22, 2020
@st-pasha st-pasha mentioned this issue Feb 22, 2020
Merged
st-pasha added a commit that referenced this issue Feb 24, 2020
@st-pasha
Exceptions reorganized (#2361)
1bf92eb 
- The exception and warning classes used by datatable are now gathered in the `datatable.exceptions` module (they used to be all over the place);
- All exceptions/warnings are now derived from the common `DtException` class;
- The base `DtException` class, when stringified, removes all backticks from the error message. This ensures that the error message looks the same in the console and when logged into a file. Consequently, many tests had to be adjusted to remove the backticks from error messages.
- The custom exception rendering mechanism ported from typesentry module into datatable and improved;
- Terminal now looks both at stdout and stderr when autodetecting color support;
- Dependency `typesentry` removed;
- Module `datatable.utils.typechecks` removed;

Closes #1535
@oleksiyskononenko oleksiyskononenko mentioned this issue Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st-pasha st-pasha

Labels
refactor Internal code changes, clean-ups or reorganizations that are not externally visible
Projects
None yet
Milestone
Release 0.11.0
Development

Successfully merging a pull request may close this issue.

Exceptions reorganized h2oai/datatable
2 participants
@st-pasha @igor-susic