Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.to_csv() and .to_jay() both crash on Windows for files larger than 4Gb #2754

Closed
oleksiyskononenko opened this issue Nov 20, 2020 · 0 comments · Fixed by #2756
Closed

.to_csv() and .to_jay() both crash on Windows for files larger than 4Gb #2754

oleksiyskononenko opened this issue Nov 20, 2020 · 0 comments · Fixed by #2756
Assignees
@oleksiyskononenko
Labels
segfault Severe bugs that lead to crashes / seg.faults / process termination
Milestone
Release 0.11.1

Comments

@oleksiyskononenko
Copy link
Contributor

The reason is the size of off_t that is 4 bytes, rather than 8.
@oleksiyskononenko oleksiyskononenko added the segfault Severe bugs that lead to crashes / seg.faults / process termination label Nov 20, 2020
@oleksiyskononenko oleksiyskononenko added this to the Release 0.11.1 milestone Nov 20, 2020
@oleksiyskononenko oleksiyskononenko self-assigned this Nov 20, 2020
@oleksiyskononenko oleksiyskononenko mentioned this issue Nov 20, 2020
Merged
oleksiyskononenko added a commit that referenced this issue Nov 21, 2020
@oleksiyskononenko
Allow reading and writing files larger than 4Gb on Windows (#2756)
2fb8872 
- use 64-bit file manipulation functions instead of 32-bit ones;
- do not rely on `off_t` size, that is 32-bit, when performing memory mapping;
- minor refactoring and cosmetics.

Closes #2725 
Closes #2754
@st-pasha st-pasha linked a pull request Dec 4, 2020 that will close this issue
Allow reading and writing files larger than 4Gb on Windows #2756
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleksiyskononenko oleksiyskononenko

Labels
segfault Severe bugs that lead to crashes / seg.faults / process termination
Projects
None yet
Milestone
Release 0.11.1
Development

Successfully merging a pull request may close this issue.

Allow reading and writing files larger than 4Gb on Windows h2oai/datatable
1 participant
@oleksiyskononenko