Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update error message for mojo_predict_df / mojo_predict_pandas #12678

Closed
exalate-issue-sync bot opened this issue May 13, 2023 · 2 comments · Fixed by #15673
Closed

update error message for mojo_predict_df / mojo_predict_pandas #12678

exalate-issue-sync bot opened this issue May 13, 2023 · 2 comments · Fixed by #15673
Labels
good_first_issue python R
Milestone
3.44.0.1

Comments

@exalate-issue-sync
Copy link

Add type check for mojo_predict_df frame parameter so that the error message clearly states that you have passed in the wrong dataframe type (for example if the user provides an H2OFrame instead of an R dataframe the error message says something like: got type H2OFrame but expected type data.frame).

same for the python api's mojo_predict_pandas.
@exalate-issue-sync
Copy link
Author

Michal Kurka commented: Just add a check and produce an error.

@hasithjp
Copy link
Member

JIRA Issue Migration Info

Jira Issue: PUBDEV-5825
Assignee: New H2O Bugs
Reporter: Lauren DiPerna
State: Open
Fix Version: N/A
Attachments: N/A
Development PRs: N/A

@Mohit1345 Mohit1345 mentioned this issue Aug 3, 2023
Merged
@wendycwong wendycwong added this to the 3.42.0.3 milestone Aug 8, 2023
@valenad1 valenad1 modified the milestones: 3.42.0.3, 3.42.0.4 Aug 22, 2023
@mn-mikke mn-mikke modified the milestones: 3.42.0.4, 3.44.0.1 Oct 2, 2023
mn-mikke added a commit that referenced this issue Oct 3, 2023
@mn-mikke
Merge pull request #15673 from Mohit1345/mojo_predict_updated
8ce883e 
[GH-12678] added check for dataframe in predict.R
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good_first_issue python R
Projects
None yet
Milestone
3.44.0.1
Development

Successfully merging a pull request may close this issue.

[GH-12678] added check for dataframe in predict.R Mohit1345/h2o-3
4 participants
@mn-mikke @wendycwong @valenad1 @hasithjp