Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom_metric_func for uplift trees. Make sure they show up in the model summary. #6783

Closed
exalate-issue-sync bot opened this issue Apr 28, 2023 · 3 comments · Fixed by #15592
Closed

Add custom_metric_func for uplift trees. Make sure they show up in the model summary. #6783

exalate-issue-sync bot opened this issue Apr 28, 2023 · 3 comments · Fixed by #15592
Assignees
@maurever
Labels
feature fixVersion/Backlog Uplift Trees
Milestone
3.44.0.1

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Apr 28, 2023 •
edited by wendycwong

Since uplift is not used in AutoML as of today, this issue is of lower priority.
@h2o-ops
Copy link
Collaborator

h2o-ops commented May 10, 2023

JIRA Issue Details

Jira Issue: PUBDEV-9019
Assignee: New H2O Bugs
Reporter: Wendy Wong
State: Open
Fix Version: Backlog
Attachments: N/A
Development PRs: N/A

@wendycwong
Copy link
Contributor

Support ticket: https://support.h2o.ai/a/tickets/104467

@wendycwong wendycwong changed the title Add/Check if custom_metric_func works for uplift trees and isotonic regression. Make sure they show up in the model summary. Add/Check if custom_metric_func works for uplift trees. Make sure they show up in the model summary. Jun 5, 2023
@maurever maurever self-assigned this Jun 16, 2023
@maurever
Copy link
Contributor

The custom metric for UpliftDRF is not implemented yet. I will add it, but it needs to be specified differently than the current general custom metric func.

@maurever maurever mentioned this issue Jun 19, 2023
Merged
maurever added a commit that referenced this issue Jul 20, 2023
@maurever
GH-6783 fix custom function definition
97a2b0c
@maurever maurever changed the title Add/Check if custom_metric_func works for uplift trees. Make sure they show up in the model summary. Add custom_metric_func works for uplift trees. Make sure they show up in the model summary. Aug 3, 2023
@maurever maurever changed the title Add custom_metric_func works for uplift trees. Make sure they show up in the model summary. Add custom_metric_func for uplift trees. Make sure they show up in the model summary. Aug 3, 2023
@maurever maurever added this to the 3.44.0.1 milestone Aug 3, 2023
maurever added a commit that referenced this issue Aug 14, 2023
@maurever
GH-6783 fix custom function definition
a32fc84
maurever added a commit that referenced this issue Sep 15, 2023
@maurever
GH-6783 Add custom metric function to UpliftDRF (#15592)
4c5a01b 
* Implement ATE, ATT, ATC metrics
* Enable custom metric for UpliftDRF
* Fix score with treatment column
* Add tests
maurever added a commit that referenced this issue Sep 20, 2023
@maurever
GH-6783 fix custom function definition
d1cf383
maurever added a commit that referenced this issue Sep 26, 2023
@maurever
GH-6783 fix custom function definition
79bb423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurever maurever

Labels
feature fixVersion/Backlog Uplift Trees
Projects
None yet
Milestone
3.44.0.1
Development

Successfully merging a pull request may close this issue.

GH-6783 Add custom metric function to UpliftDRF h2oai/h2o-3
3 participants
@wendycwong @h2o-ops @maurever