AutoML: user can create multiple AutoML instances with the same startTime.

[exalate-issue-sync]

h4. From: [https://gitter.im/h2oai/h2o-3?at=60b4ddd63d43a15a65d79304|https://gitter.im/h2oai/h2o-3?at=60b4ddd63d43a15a65d79304|smart-link]

Simon Schmid
@SimonSchmid
May 31 15:00
Hi all, I found a bug in the AutoML class, see [https://github.com/h2oai/h2o-3/blob/ff45788d86eda742eb0464d66d938094250b32e8/h2o-automl/src/main/java/ai/h2o/automl/AutoML.java#L93|https://github.com/h2oai/h2o-3/blob/ff45788d86eda742eb0464d66d938094250b32e8/h2o-automl/src/main/java/ai/h2o/automl/AutoML.java#L93]. The synchronization is working properly for 2 concurrent calls but not for more than 2. If there are e.g. 3 concurrent calls at 12:00:00, all will have the same startTime. The first processed one then will take 12:00:00 as startTime and the second call will first wait and then retrieve new start times until it is at least 12:00:01. 12:00:01 will then be saved as lastStartTime which means that the third call is actually fine with keeping 12:00:00. This will then result in an error as it produces duplicate models ids together with the run of the first call. Not sure what the best fix is, probably just checking that startTime is a time after lastStartTime .

[~accountid:5b153fb1b0d76456f36daced] : This probably creates an issue as indivual models are named after this {{startTime}}. Maybe we can just use a counter instead (incremented on each AutoML instance) and add it to models ids, if the only issue comes from model names.

[h2o-ops]

JIRA Issue Details

Jira Issue: PUBDEV-8175
Assignee: Sebastien Poirier
Reporter: Sebastien Poirier
State: Resolved
Fix Version: 3.34.0.1
Attachments: N/A
Development PRs: Available

[h2o-ops]

Linked PRs from JIRA

#5532
h2oai/sparkling-water#2541