-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUBDEV-8175: improve AutoML behaviour when multiple instances are created in parallel #5532
Conversation
1fd2685
to
f2c0a67
Compare
I will probably get to a proper review on Monday but I realized this might mess up explanations a bit (models could have the whole name including timestamp instead of being shortened which is not practical in the plots)... If this PR changes the format of default model names, would you mind changing a regex in these two functions in this PR:
|
@tomasfryda do you remember why you have asecond capturing group in this regexp? gsub("(.*)_AutoML_\\d{8}_\\d{6}(.*)", "\\1\\2", model_ids) the (previous) model names should always end with Btw, didn't notice that we have AutoML-specific logic in generic functions like |
The final one should be used if it's a model from a grid I think, e.g., I wouldn't say it's specific to |
@tomasfryda regexp should be fixed, please have a look. |
I'd use Otherwise everything looks ok. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @sebhrusen!
https://h2oai.atlassian.net/browse/PUBDEV-8175