h2o.removeAll() in R is removing all keys (including retained) from list h2o.ls() although frames are still accessible

[exalate-issue-sync]

{noformat}titanic <- h2o.importFile("https://s3.amazonaws.com/h2o-public-test-data/smalldata/gbm_test/titanic.csv")
titanic2 <- h2o.importFile("https://s3.amazonaws.com/h2o-public-test-data/smalldata/gbm_test/titanic.csv")
h2o.ls(){noformat}

{quote}A data.frame: 2 × 1
key

titanic.hex_sid_82b9_70
titanic.hex_sid_82b9_71{quote}

{noformat}h2o.removeAll(retained_elements = c(h2o.keyof(titanic)))
h2o.ls(){noformat}

{quote}A data.frame: 0 × 1

key

{quote}

^no keys listed. Sounds like they are all removed and none were retained.

However, {{titanic}} and {{titanic2}} are still accessible.

[exalate-issue-sync]

Neema Mashayekhi commented: Note that this issue was not found in with Python client

[exalate-issue-sync]

Erin LeDell commented: [~accountid:5dc4f5bbb6e6b50c58af0624] This does look like a bug (the {{titanic}} H2OFrame should be retained).

However, just in case it’s not clear, using {{h2o.removeAll()}} should only remove the H2OFrames on the backend. The corresponding R objects, {{titanic}} and {{titanic2}} still exist but they only contain metadata and you can’t actually get the H2OFrames back (so that works as expected).

[exalate-issue-sync]

Michal Kurka commented: Erin’s assessment seems correct to me, the main issue is that the “retained_elements” parameter is not propagated to the backend.

11-12 09:08:41.435 192.168.86.136:54321  87216  7712235-18  INFO water.default: DELETE /3/DKV, parms: {retained_keys=[]}

This happens because you are passing keys instead of objects and this piece of code discards the argument:

for (element in retained_elements) {
if (is(element, "H2OModel")) {
retained_keys <- append(retained_keys, element@model_id)
} else if (is.H2OFrame(element)) {
retained_keys <- append(retained_keys, h2o.getId(element))
}
}

Documentation should be clarified and the code fixed in order to either accept keys as well or fail on incorrect input.

[h2o-ops]

JIRA Issue Migration Info

Jira Issue: PUBDEV-7896
Assignee: Adam Valenta
Reporter: Neema Mashayekhi
State: Resolved
Fix Version: 3.32.0.3
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#5137