PUBDEV-7896 - do not discard Keys in h2o.removeAll() command

[valenad1]

https://h2oai.atlassian.net/browse/PUBDEV-7896

[honzasterba]

test is missing

[michalkurka]

@Pscheidl this is your code, please review @valenad1's changes

[Pscheidl]

Thank you @valenad1 - It's a good move to accept the keys as strings as well.

• Document the behavior in method's description
• What happens if users add wrong/nonexistent key ? The DKVManager itself should ignore it and just move on. Is this acceptable for users ? I think yes. Accepting only the objects was a double-edged sword and server partially as a protection against that - it's easy to pass a string, yet it's not as easy to pass your own estimator. 😉

For tests, the runit_retain.R might be extended to test the new functionality.

[valenad1]

Thank you @valenad1 - It's a good move to accept the keys as strings as well.

* Document the behavior in method's description

Documented.

* What happens if users add wrong/nonexistent key ? The DKVManager itself should ignore it and just move on. Is this acceptable for users ? I think yes. Accepting only the objects was a double-edged sword and server partially as a protection against that - it's easy to pass a string, yet it's not as easy to pass your own estimator. 😉

For tests, the runit_retain.R might be extended to test the new functionality.

I agree, when user makes a typo in string then something can be accidentally lost without any warning. I improve this behavior to check if provided key is in h2o.ls() and if not then do not perform remove. Please check.

If user provide something different than Frame or Model then it also do not perform remove.

[michalkurka]

Thank you!