Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when loading the same data with the same query - it is overwriting the data in memory (changing the frame in memory) #7801

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 5 comments

Comments

@exalate-issue-sync
Copy link

when loading the same data with the same query - it is overwriting the data in memory (changing the frame in memory).

Example pseudo code:

on same instance and cluster

df1 = import_sql_select(table1, fetch_mode = “SINGLE”)
df2 = import_sql_select(table1, fetch_mode = “DISTRIBUTED”)

when referencing the parameters for df1 then it is returning the parameters of df2 ,,
since it has already overwritten the df1 info by df2's info
which means when I try to get parameters such as “max” or “min” of “df1” it is returning me the “min” and “max” of df2.

See the reference attachment.

@exalate-issue-sync
Copy link
Author

Retima Dangol commented: [https://0xdata.atlassian.net/browse/PUBDEV-7840|https://0xdata.atlassian.net/browse/PUBDEV-7840|smart-link]

It shouldn't be problem( or wouldn’t have noticed) if the data received as (fetch_mode = distributed | single) would have been same, as expected but they are not (jira above).

@exalate-issue-sync
Copy link
Author

Ondrej Nekola commented: Base of the fix tested by [~accountid:5d1185d3912da30c634707cb] . The PR: [https://github.com//pull/5064|https://github.com//pull/5064|smart-link]

@exalate-issue-sync
Copy link
Author

Ondrej Nekola commented: [~accountid:5d1185d3912da30c634707cb] It would be problem anyway, because the data would be overwriten even if they would come from a different database just with the same table name. Or from a different select from the same table (e.g. read {{id}} and {{name}} from {{users}} to {{frame1}} and then read {{id}} and {{rating}} to a {{frame2}} would rewrite {{frame1}})

@exalate-issue-sync
Copy link
Author

Ondrej Nekola commented: Fixed.

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Migration Info

Jira Issue: PUBDEV-7841
Assignee: Ondrej Nekola
Reporter: Retima Dangol
State: Resolved
Fix Version: 3.32.1.1
Attachments: Available (Count: 2)
Development PRs: Available

Linked PRs from JIRA

#5064

Attachments From Jira

Attachment Name: image-2020-10-15-12-27-48-015.png
Attached By: Retima Dangol
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-7841/image-2020-10-15-12-27-48-015.png

Attachment Name: snowflakes_with_server (1).html
Attached By: Retima Dangol
File Link:https://h2o-3-jira-github-migration.s3.amazonaws.com/PUBDEV-7841/snowflakes_with_server (1).html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant