PUBDEV-7841 don't overwrite existing frame when data loaded again fro… #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pscheidl
approved these changes
Oct 22, 2020
Pscheidl
reviewed
Oct 22, 2020
Pscheidl
reviewed
Oct 22, 2020
satai
force-pushed
the
ondra/PUBDEV-7841
branch
2 times, most recently
from
dbf09a2
to
1b000cd
Compare
michalkurka
reviewed
Oct 23, 2020
| Objects.requireNonNull(postfix); | ||
|
|
||
| final String s = prefix + "_" + rand() + (postfix.isEmpty() ? "" : ("_" + postfix)); | ||
| final String withoutWhitechars = s.replaceAll("\\W", "_"); |
There was a problem hiding this comment.
This behavior doesn't belong in this class (changes requested).
michalkurka
reviewed
Oct 23, 2020
| @@ -46,7 +46,7 @@ | |||
| final Boolean useTempTable, final String tempTableName, | |||
| final SqlFetchMode fetchMode, final Integer numChunksHint) { | |||
|
|
|||
| final Key<Frame> destination_key = Key.make((table + "_sql_to_hex").replaceAll("\\W", "_")); | |||
| final Key<Frame> destination_key = Key.makeRandom(table, "sql_to_hex"); | |||
There was a problem hiding this comment.
Instead of using a partially randomized key, I think it is cleaner to follow a similar pattern as we use for naming models - just use an increasing sequence of numbers for a suffix, see H2O#calcNextUniqueModelId for inspiration.
it could be even very simple, something like
private static AtomicLong nextTableNum = new AtomicLong(0);
...
final Key<Frame> destination_key = Key.make((table.replaceAll("\\W", "_") + "_sql_to_hex_" + nextTableNum.addAndGet(1)));
The advantage definitely is that it is clear in what order the keys were created - which could be useful in debugging.
There was a problem hiding this comment.
OK, you can have a look.
satai
force-pushed
the
ondra/PUBDEV-7841
branch
3 times, most recently
from
8705b31
to
2355dba
Compare
Pscheidl
approved these changes
Oct 26, 2020
michalkurka
approved these changes
Oct 26, 2020
satai
force-pushed
the
ondra/PUBDEV-7841
branch
from
2355dba
to
2195290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://h2oai.atlassian.net/browse/PUBDEV-7841