Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GBM can fail when it encounters a bin with just one single value and NAs #8121

Closed
exalate-issue-sync bot opened this issue May 11, 2023 · 1 comment
Closed

Comments

@exalate-issue-sync
Copy link

A regression was introduced in PUBDEV-7486. GBM can sometimes fail if histogram bin only has a single value and the rest of it is NAs. Reproduced on the Springleaf dataset:

{noformat}> unique(DF[,"VAR_0018"])
[1] 0 NA{noformat}

Exception (needs to have assertions enabled):

{noformat}[2020-04-28T05:28:00.878Z] java.lang.AssertionError: broken histo range VAR_0018:0.0-1.0 step=1.0 nbins=1 isInt=1
[2020-04-28T05:28:00.878Z] at hex.tree.DTree$UndecidedNode.scoreCols(DTree.java:345)
[2020-04-28T05:28:00.878Z] at hex.tree.DTree$UndecidedNode.(DTree.java:324)
[2020-04-28T05:28:00.878Z] at hex.tree.gbm.GBM$GBMDriver.growTrees(GBM.java:473)
[2020-04-28T05:28:00.878Z] at hex.tree.gbm.GBM$GBMDriver.buildNextKTrees(GBM.java:385)
[2020-04-28T05:28:00.878Z] at hex.tree.SharedTree$Driver.scoreAndBuildTrees(SharedTree.java:442)
[2020-04-28T05:28:00.878Z] at hex.tree.SharedTree$Driver.computeImpl(SharedTree.java:362)
[2020-04-28T05:28:00.878Z] at hex.ModelBuilder$Driver.compute2(ModelBuilder.java:248)
[2020-04-28T05:28:00.878Z] at water.H2O$H2OCountedCompleter.compute(H2O.java:1557)
[2020-04-28T05:28:00.878Z] at jsr166y.CountedCompleter.exec(CountedCompleter.java:468)
[2020-04-28T05:28:00.878Z] at jsr166y.ForkJoinTask.doExec(ForkJoinTask.java:263)
[2020-04-28T05:28:00.878Z] at jsr166y.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:974)
[2020-04-28T05:28:00.878Z] at jsr166y.ForkJoinPool.runWorker(ForkJoinPool.java:1477)
[2020-04-28T05:28:00.878Z] at jsr166y.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:104){noformat}

@h2o-ops
Copy link
Collaborator

h2o-ops commented May 14, 2023

JIRA Issue Migration Info

Jira Issue: PUBDEV-7517
Assignee: Michal Kurka
Reporter: Michal Kurka
State: Resolved
Fix Version: 3.30.0.3
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#4590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant