Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUBDEV-7517: GBM can fail when tree node has just one single value and NAs #4590

Merged
merged 1 commit into from May 8, 2020
Merged

PUBDEV-7517: GBM can fail when tree node has just one single value and NAs #4590

merged 1 commit into from May 8, 2020

Conversation

michalkurka
Copy link
Contributor

@michalkurka michalkurka commented May 7, 2020 •
edited

No description provided.

@michalkurka michalkurka marked this pull request as draft May 7, 2020 17:53
@michalkurka michalkurka changed the base branch from master to rel-zahradnik May 7, 2020 17:53
honzasterba
honzasterba approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@honzasterba honzasterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

h2o-algos/src/main/java/hex/tree/DHistogram.java Show resolved Hide resolved
@michalkurka michalkurka marked this pull request as ready for review May 8, 2020 01:50
@michalkurka michalkurka merged commit e7336ff into rel-zahradnik May 8, 2020
@h2o-ops h2o-ops mentioned this pull request May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honzasterba honzasterba honzasterba approved these changes

@Pscheidl Pscheidl Pscheidl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michalkurka @honzasterba @Pscheidl