-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-7079] Added verbose param to h2o.init() and guarded h2o.conn.show_status() in h20.py #7079 [nocheck] #15653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
h2o-py/h2o/h2o.py
Outdated
@@ -136,7 +136,7 @@ def connection(): | |||
def init(url=None, ip=None, port=None, name=None, https=None, cacert=None, insecure=None, username=None, password=None, | |||
cookies=None, proxy=None, start_h2o=True, nthreads=-1, ice_root=None, log_dir=None, log_level=None, | |||
max_log_file_size=None, enable_assertions=True, max_mem_size=None, min_mem_size=None, strict_version_check=None, | |||
ignore_config=False, extra_classpath=None, jvm_custom_args=None, bind_to_localhost=True, **kwargs): | |||
ignore_config=False, extra_classpath=None, jvm_custom_args=None, bind_to_localhost=True,verbose = True, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: missing space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mn-mikke last commit "added space" is rebased and also space is added in it
Please rebase the change to |
…i#15681) * ht/adding disclaimer in docs * ht/added flow & download page * ht/updated download page * ht/added security documentation section * ht/user guide updates * ht/uniformity * ht/added additional note to welcome page * callouts * ht/banner color switch * ht/rename callout --------- Co-authored-by: Jeff Fohl <jfohl@h2o.ai>
…the change should be made in standalone test. He provides the code and I just copied and pasted. (h2oai#15675)
…ster.show_status()
74c62ee
to
0332bca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor suggestion.
Closes #7079
1.Added verbose parameter to init() in h2o.py, allowing users to control the verbosity during initialization.
2. The 'verbose' parameter is set to True by default (similar to h2o.connect() as said in issue).
3.The h2oconn.cluster.show_status() call is now guarded and will be executed only when 'verbose' is True.
4.Additionally, a comment has been added to the h2o.init() function to explain the purpose of the 'verbose' parameter and its default value.
Fixes #7079