PUBDEV-5230: Update import statement for PCA #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCA is now an estimator. Previous examples imported using: `from h2o.transforms.decomposition import H2OPCA` For this issue, I changed all of these examples to `from h2o.estimators.pca import H2OPrincipalComponentAnalysisEstimator` or `from h2o.estimators.pca import H2OPrincipalComponentAnalysisEstimator as H2OPCA` (where appropriate)
When using from h2o.estimators.pca import H2OPrincipalComponentAnalysisEstimator in scikit learn examples, an error occurs when running fit(). Reverting the import statement for these tests until a fix can be found. Note that from h2o.transforms.decomposition import H2OPCA is still supported for backward compatibility.
|
Since there are errors in the booklet (and not just the demos) when we change the import statement to use It would be weird to only change some of the import statements in the booklet, so let's just wait on merging this until PUBDEV-5236 is complete. Thanks! |
added 2 commits
January 23, 2018 13:40
Using h2o.estimators.pca import H2OPrincipalComponentAnalysisEstimator in scikit learn examples no longer gives an error when running fit().
Using h2o.estimators.pca import H2OPrincipalComponentAnalysisEstimator in scikit learn examples no longer gives an error when running fit().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCA is now an estimator. Previous examples imported using:
from h2o.transforms.decomposition import H2OPCAFor this issue, I changed all of these examples to
from h2o.estimators.pca import H2OPrincipalComponentAnalysisEstimatoror
from h2o.estimators.pca import H2OPrincipalComponentAnalysisEstimator as H2OPCA(where appropriate)