Vlad udf take3 #366
Closed
Vlad udf take3 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chunk - added a universal setter. TypeMap - slightly improved the icing locking message NewChunkTest - made the test more detailed C16ChunkTest - added a test case for setting uuid TestUtil - added a registry for objects to be dropped at the end of a test
Chunk - added a universal setter. TypeMap - slightly improved the icing locking message NewChunkTest - made the test more detailed C16ChunkTest - added a test case for setting uuid TestUtil - added a registry for objects to be dropped at the end of a test
…her bytes of a UUID are all zeros. Added a bunch of test cases for that in C16ChunkTest.
C16Chunk - code deduplication; added a uuid setter (two longs); some encapsulation (replacing exporting _LO_NA, _HI_NA with method isNA()) Chunk - added addUUID() methods, one takes a UUID. Checking if UUID has a valid value. NewChunk - implemented behavior for UUID BufferedString - fixed an exception in toString() FVecParseWriter, ParseUUID - switched from long[] to UUID for representing uuids MRUtils.sampleFrame - checking value for a NA (or else it can throw) Added test cases for illegal uuids.
Made sure ColumnTest passes, with the uuids it generates, etc. So it's a step in the direction of typed UDF. Next will specialize the ops, so we won't be able to add a date to a vector of uuids etc. Also, PrettyPrint.UUID renamed to PrettyPrint.uuid, etc.
Chunk - added a universal setter. TypeMap - slightly improved the icing locking message NewChunkTest - made the test more detailed C16ChunkTest - added a test case for setting uuid TestUtil - added a registry for objects to be dropped at the end of a test
Chunk - added a universal setter. TypeMap - slightly improved the icing locking message NewChunkTest - made the test more detailed C16ChunkTest - added a test case for setting uuid TestUtil - added a registry for objects to be dropped at the end of a test
…her bytes of a UUID are all zeros. Added a bunch of test cases for that in C16ChunkTest.
C16Chunk - code deduplication; added a uuid setter (two longs); some encapsulation (replacing exporting _LO_NA, _HI_NA with method isNA()) Chunk - added addUUID() methods, one takes a UUID. Checking if UUID has a valid value. NewChunk - implemented behavior for UUID BufferedString - fixed an exception in toString() FVecParseWriter, ParseUUID - switched from long[] to UUID for representing uuids MRUtils.sampleFrame - checking value for a NA (or else it can throw) Added test cases for illegal uuids.
Made sure ColumnTest passes, with the uuids it generates, etc. So it's a step in the direction of typed UDF. Next will specialize the ops, so we won't be able to add a date to a vector of uuids etc. Also, PrettyPrint.UUID renamed to PrettyPrint.uuid, etc.
# Conflicts: # h2o-core/src/main/java/hex/Model.java # h2o-core/src/main/java/water/fvec/Chunk.java # h2o-core/src/main/java/water/fvec/Col.java # h2o-core/src/main/java/water/fvec/Vec.java # h2o-core/src/test/java/water/TestUtil.java # h2o-core/src/test/java/water/fvec/ColumnTest.java # h2o-core/src/test/java/water/fvec/NewChunkTest.java # h2o-docs/src/front/index.html
Removed setAny, as it's not required anymore, we have typed chunks.
Col: removed unreferenced classes, made them anonymous. Made sure data type code is passed to Vec before it's being filled. Still a hack.
|
Tests passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is