Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUBDEV-8276 fix NPE when weight_column is not in training frame #5630

Merged
merged 5 commits into from
Aug 23, 2021

Conversation

maurever
Copy link
Contributor

@maurever maurever self-assigned this Aug 18, 2021
Copy link
Contributor

@michalkurka michalkurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you - improvements suggested

Copy link
Contributor

@sebhrusen sebhrusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maurever !

@michalkurka
Copy link
Contributor

thanks for making the changes @maurever

@maurever maurever merged commit 43aceed into master Aug 23, 2021
@maurever maurever deleted the maurever_PUBDEV-8276 branch August 31, 2021 11:13
maurever added a commit that referenced this pull request Oct 5, 2021
PUBDEV-8276 fix NPE, add test

Co-authored-by: Seb <sebastien@h2o.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants