PUBDEV-4940 UpliftDRF documentation [nocheck] #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added documentation pages - added params/algo to toctree; minor syntax updates, still need to add image to Uplift DRF; rst files only - added image; toctree algo shift - updated api comments - add comma - fix python example, it was failing on assertion error and uplift_model does not have plot_auuc() method - fix test in uplift_metric, it failing on assert - fix all available in
…update main doc page
|
@hannah-tillman, could you please make a review of this documentation again? I made a few changes of the main page, add more information and change the API a little bit. Thanks a lot! |
hannah-tillman
approved these changes
Dec 1, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
valenad1
reviewed
Dec 2, 2021
|
@maurever handled a few of the suggestions that were doc-centered: shifted the demo to under the intro and merged the references; also updated the one FAQ to say Uplift DRF |
Thanks, @hannah-tillman, you implemented all suggestions! I will just separate back the references and sources, it make sense to me. |
valenad1
approved these changes
Dec 2, 2021
maurever
changed the title
maurever
force-pushed
the
maurever_PUBDEV-4940_uplift_doc
branch
from
f5e62bd
to
7bf3497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://h2oai.atlassian.net/browse/PUBDEV-4940
Documentation for UpliftDRF algorithm.
Minor API changes.