PUBDEV-4940 Uplift trees doc #5565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e better data in test, fix cross validation
This reverts commit 64045d0.
…iftRF implementation
…oai/h2o-3 into maurever_PUBDEV-4940_uplift_trees_poc
20 tasks
maurever
force-pushed
the
maurever_PUBDEV-4940_uplift_trees_doc
branch
from
98985bf
to
71d5a8e
Compare
|
@hannah-tillman could you review the documentation part, please? All .rst files and API comments. Thanks! |
hannah-tillman
approved these changes
Aug 10, 2021
valenad1
reviewed
Aug 12, 2021
valenad1
reviewed
Aug 12, 2021
valenad1
approved these changes
Aug 13, 2021
|
Thanks, @valenad1 for your review and contributions! |
valenad1
reviewed
Aug 18, 2021
maurever
force-pushed
the
maurever_PUBDEV-4940_uplift_trees_doc
branch
2 times, most recently
from
d510d27
to
62c62ee
Compare
- added documentation pages - added params/algo to toctree; minor syntax updates, still need to add image to Uplift DRF; rst files only - added image; toctree algo shift - updated api comments - add comma - fix python example, it was failing on assertion error and uplift_model does not have plot_auuc() method - fix test in uplift_metric, it failing on assert - fix all available in
maurever
force-pushed
the
maurever_PUBDEV-4940_uplift_trees_doc
branch
from
62c62ee
to
00e5db4
Compare
|
The doc changes were cherry-picked to the final UpliftPR #5224. |
|
The doc changes were cherry-picked to the other separate UpliftDRF doc PR. #5918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://h2oai.atlassian.net/jira/software/c/projects/PUBDEV/issues/PUBDEV-4940
To review documentation pages, jump here: https://github.com/h2oai/h2o-3/pull/5565/files#diff-bcabcde0e4e0ba2b80bf918b10b6e630ca21e956185504e03297b865b0691545