PUBDEV-8696 Uplift API cleanup and fix #6187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebhrusen Can you check it from API point of view. I have moved Uplift specific stuff from ModelBase to H2OBinomialUpliftModel |
Those are Uplift specific fields. I move them from common metric_base.py to specific binomial_uplift.py
…OBinomialUpliftModel
valenad1
force-pushed
the
valenad-PUBDEV-8696-uplift-api-fix
branch
from
015f26f
to
656b786
Compare
sebhrusen
reviewed
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://h2oai.atlassian.net/browse/PUBDEV-8696