Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUBDEV-8910: updated logo, favicon, background, and front version number #6424

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

hannah-tillman
Copy link
Contributor

Copy link
Contributor

@sebhrusen sebhrusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @hannah-tillman

@sebhrusen
Copy link
Contributor

sebhrusen commented Nov 15, 2022

@hannah-tillman do we keep the "old yellow" for this doc page? http://h2o-release.s3.amazonaws.com/h2o/rel-zygmund/2/docs-website/index.html
Where is that page accessible from by the way when not accessed directly from s3?

@hannah-tillman
Copy link
Contributor Author

@hannah-tillman do we keep the "old yellow" for this doc page? http://h2o-release.s3.amazonaws.com/h2o/rel-zygmund/2/docs-website/index.html Where is that page accessible from by the way when not accessed directly from s3?

Well, the image seems to be the same color as the "bright yellow" so I don't see an issue with it. Plus, I don't know if it is accessible anywhere but directly from s3. I only ever access it when I test the new proxy pass link.

@valenad1
Copy link
Collaborator

@hannah-tillman do we keep the "old yellow" for this doc page? http://h2o-release.s3.amazonaws.com/h2o/rel-zygmund/2/docs-website/index.html Where is that page accessible from by the way when not accessed directly from s3?

Well, the image seems to be the same color as the "bright yellow" so I don't see an issue with it. Plus, I don't know if it is accessible anywhere but directly from s3. I only ever access it when I test the new proxy pass link.

I cannot find the place from its accessible also..

Maybe we can focus also on Python docs accessible from here: https://docs.h2o.ai/h2o-3/index.html
and H2O download page accessible from here: https://h2o.ai/resources/download/

Copy link
Collaborator

@valenad1 valenad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my local, thank you!

I wander if we should change branding on fix release or it is big enough to have it in major release and this PR should go to to master... wdyt @sebhrusen ?

@sebhrusen
Copy link
Contributor

I wander if we should change branding on fix release or it is big enough to have it in major release and this PR should go to to master...

it doesn't fit into usual categories, but as it's not a new feature and could easily be considered as a fix of our documentation in order to follow our new style guide/brand identity, then I don't mind having this released asap.
But I'll leave the final decision to our release manager @mn-mikke :)

@mn-mikke
Copy link
Collaborator

I'm not against having this change in the fix release. This PR should't affect stability or behavior of the product.

@hannah-tillman hannah-tillman merged commit beb1cf7 into rel-zygmund Nov 18, 2022
@hannah-tillman hannah-tillman deleted the PUBDEV-8910 branch November 18, 2022 18:41
@h2o-ops h2o-ops mentioned this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants