-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUBDEV-8910: updated logo, favicon, background, and front version number #6424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks @hannah-tillman
@hannah-tillman do we keep the "old yellow" for this doc page? http://h2o-release.s3.amazonaws.com/h2o/rel-zygmund/2/docs-website/index.html |
Well, the image seems to be the same color as the "bright yellow" so I don't see an issue with it. Plus, I don't know if it is accessible anywhere but directly from s3. I only ever access it when I test the new proxy pass link. |
I cannot find the place from its accessible also.. Maybe we can focus also on Python docs accessible from here: https://docs.h2o.ai/h2o-3/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my local, thank you!
I wander if we should change branding on fix release or it is big enough to have it in major release and this PR should go to to master... wdyt @sebhrusen ?
it doesn't fit into usual categories, but as it's not a new feature and could easily be considered as a fix of our documentation in order to follow our new style guide/brand identity, then I don't mind having this released asap. |
I'm not against having this change in the fix release. This PR should't affect stability or behavior of the product. |
For: PUBDEV-8910