-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe for conda build #667 #671
Conversation
…name. Removing sklearn
…rc build issue (#662) * Fixes glm notebook, splitting animation and run due to unknown issue. * minor fixes for build * Fix broken parallel mode for glm * ensure xgboost is updated during make fullinstall * don't use proc_bind(master)
* Update xgboost * Update requirements * Update xgboost and resolve cmake issue * Fix arch issues for ppc
…a.yaml with Jinja errors
…Jenkins with Jinja template errors
…e files should have generated appropriately.
@mdymczyk and @pseudotensor , X86_64 build via jenkins for all cuda versions (8,9,9.2) is working for this PR. For ppc64le we have 2 issues
What are your thoughts on approach this? Can we merge this PR for x86_64 build ? |
@hemenkapadia please don't merge anything that fails (either ppc64le or X86_64). If it's too much work and we don't need it immediately (or at all) then I'd say we should just skip it during ppc64le build and only build it for x86_64.
Can we try removing that LLVM stuff from the docker and see if it still works? |
Ya, definitely don't merge if not green. But as we discussed, I don't see why llvm is needed, so remove it unless I'm confused. |
…alled from aws artifacts
…il as not repo was found
All checks passed now. We discussed on PR#678 that llvm is needed for llvmlite which is a dependency for numba. Since all checks are passing if you are ok please approve this PR so that I can merge to dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have many new blocks of code that are commented out. Can you just remove them?
…o conda builds for ppc64le for now.
Added functionality to generate conda packages in addition to the wheel files as part of the Jenkins build process. This still does not auto deploy the conda packages to h2oai conda channel, however that can be easily implemented by providing a promote option on our internal conda server.
Issue #667