This repository has been archived by the owner on Jul 20, 2018. It is now read-only.
Prepare for release #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
commented
May 22, 2018
| - SPARKLINGWATER_VERSION="2.3.4" |
There was a problem hiding this comment.
Update to later versions, remove unsupported versions 2.0 and 1.6
navdeep-G
reviewed
May 22, 2018
| @@ -127,61 +130,18 @@ Advanced users may want to choose a particular Sparking Water / H2O version (spe | |||
| | | 2.1.2 | 3.10.4.2 | "rel-ueno" | "2" | | |||
| | | 2.1.1 | 3.10.4.2 | "rel-ueno" | "2" | | |||
| | | 2.1.0 | 3.10.3.2 | "rel-tverberg" | "2" | | |||
| | | | | | | | |||
| | 2.0.* | 2.0.28 | 3.18.0.8 | "rel-wolpert" | "8" | | |||
There was a problem hiding this comment.
Can you explain why this is not supported anymore? Can't this information still be useful to people?
There was a problem hiding this comment.
We don't want people to use these versions. They are not mentioned on download page, pipy, in Sparkling Water documentations. RSparkling is the last step.
If anybody needs to use the older version, they have to make some effort or upgrade
There was a problem hiding this comment.
Got it, just wanted to be sure. Thx!
navdeep-G
approved these changes
May 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed support for 1.6 and 2.0 as we are not really supporting then. Updated also the links to point to the latest versions.
Ofter we merge this PR, we need to make
stablebranch up-to-date with master and then release.@navdeep-G Please don't runt this time
./prepare-data-files.shI already run it and merged the change (had to tweak the script about the non-existent Sparkling Water release :D )