Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probability calibration does not work in Sparkling Water Dataframe API #4507

Closed
exalate-issue-sync bot opened this issue May 22, 2023 · 2 comments
Closed
Assignees

Comments

@exalate-issue-sync
Copy link

originally posted as a github issue [here|https://github.com//issues/1108]:

Although when calibration is enabled, EasyPredictModelWrapper returns a BinomialModelPrediction object which contains both raw probs and calibrated probs, the
implicit conversion defined here
{code}
sparkling-water/ml/src/main/scala/org/apache/spark/ml/h2o/models/H2OMOJOModel.scala

Lines 81 to 83 in 9968342

implicit def toBinomialPrediction(pred: AbstractPrediction) = BinomialPrediction(
pred.asInstanceOf[BinomialModelPrediction].classProbabilities(0),
pred.asInstanceOf[BinomialModelPrediction].classProbabilities(1))
{code}
transforms the BinomialModelPrediction object to a BinomialPrediction, which only contains raw probs (p0, and p1) and calibrated probabilities are NOT returned. Both raw and calibrated probabilities should be returned to the user.

@DinukaH2O
Copy link

JIRA Issue Migration Info

Jira Issue: SW-1249
Assignee: Jakub Hava
Reporter: Lauren DiPerna
State: Resolved
Fix Version: 2.1.54
Attachments: N/A
Development PRs: Available

Linked PRs from JIRA

#1174

@hasithjp
Copy link
Member

JIRA Issue Migration Info Cont'd

Jira Issue Created Date: 2019-04-25T17:44:22.195-0700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants