[SW-341] Python version independent distribution #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, looks good! 👍 |
mdymczyk
approved these changes
Mar 2, 2017
jakubhava
approved these changes
Mar 2, 2017
This was referenced Mar 6, 2017
mmalohlava
force-pushed
the
mm/jira/sw-341
branch
from
be7f1c1
to
cc80a23
Compare
jakubhava
reviewed
Mar 15, 2017
gradle/spark.gradle
Outdated
| @@ -100,7 +100,7 @@ task printIntegTestEnv { | |||
| println("-Dspark.testing=true\n" + | |||
| "-Dsparkling.assembly.jar=${project(":sparkling-water-assembly").configurations.shadow.artifacts.file.join(',')}\n" + | |||
| "-Dsparkling.itest.jar=${integTestJar.archivePath}\n" + | |||
| "-Dsparkling.pysparkling.egg=${project(":sparkling-water-py").configurations.eggs.artifacts.file.join(',')}\n" + | |||
| "-Dsparkling.pysparkling.egg=${project(":sparkling-water-py").configurations.sdist.artifacts.file.join(',')}\n" + | |||
There was a problem hiding this comment.
-Dsparkling.pysparkling.egg needs to be changed to sparkling.pysparkling.sdist set correct variable
|
@mmalohlava this still need a small change - Python Integ test will fail because |
|
@h2o-ops please verify! |
|
Hi @mmalohlava, your PR title is missing JIRA issue number! |
|
Any update on this? |
|
No. Maybe I did something wrong? Sorry for that. I just downloaded it.
Thank you!
Best wishes,
Minming Li
From: Aaron Duke [mailto:notifications@github.com]
Sent: Monday, April 10, 2017 2:30 PM
To: h2oai/sparkling-water
Cc: Subscribed
Subject: Re: [h2oai/sparkling-water] [SW-341] Python version independent distribution (#195)
Any update on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#195 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYLVWe3R9G5r91MstCreoG0c_owc3wu2ks5runUigaJpZM4MQpEJ>.
…________________________________
NOTICE TO RECIPIENT(S) OF INFORMATION: This message may contain information that is proprietary or confidential to Healthagen or its subsidiaries, and is for your use only. This message may also contain Personally Identifiable Information or Protected Health Information, including various kinds of information about specific medical or mental health conditions, procedures, medications, etc. Disclosure of any such information to anyone other than the recipient of this message is restricted by Federal laws and regulations, State laws and regulations, or both. Unless it is otherwise permitted by such laws and regulations, any disclosure of this information requires the express written consent of the person to whom it pertains. If you have received this message in error, please notify the sender immediately by return e-mail and delete the message and any attachments. Thank you.
|
|
@aadu we are going to release it in the next release (in two weeks after releasing a new H2O version). We were mainly waiting for feedback from people using pysparkling since the PR changes how we are delivering python PySpakling package. |
|
Thanks! I am new to H2O. I am still learning. ☺
Best wishes,
Minming Li
From: Michal Malohlava [mailto:notifications@github.com]
Sent: Monday, April 10, 2017 2:41 PM
To: h2oai/sparkling-water
Cc: Li, Minming; Comment
Subject: Re: [h2oai/sparkling-water] [SW-341] Python version independent distribution (#195)
@aadu<https://github.com/aadu> we are going to release it in the next release (in two weeks after releasing a new H2O version).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#195 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYLVWUx72AVY5iRip_Xyan87ejBY50_7ks5runeggaJpZM4MQpEJ>.
…________________________________
NOTICE TO RECIPIENT(S) OF INFORMATION: This message may contain information that is proprietary or confidential to Healthagen or its subsidiaries, and is for your use only. This message may also contain Personally Identifiable Information or Protected Health Information, including various kinds of information about specific medical or mental health conditions, procedures, medications, etc. Disclosure of any such information to anyone other than the recipient of this message is restricted by Federal laws and regulations, State laws and regulations, or both. Unless it is otherwise permitted by such laws and regulations, any disclosure of this information requires the express written consent of the person to whom it pertains. If you have received this message in error, please notify the sender immediately by return e-mail and delete the message and any attachments. Thank you.
|
mmalohlava
force-pushed
the
mm/jira/sw-341
branch
from
cc80a23
to
b8d030f
Compare
|
@mmalohlava I was wondering how close we are on this. I don't mean to pester you, but it's going to solve several headaches for me. Thanks |
|
Hi @aadu, this change is going into the next sparkling water release 2.1.6. The current version is 2.1.5. |
|
@mmalohlava we could merge this change into master now, what do you think ? |
|
Just curious if this is going to happen soon as we're on 2.1.7 now. Is there a holdup still in terms of merging this? |
Minor build tweaks
Change version to actual master integration version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.