[SW-2146] Cleanup in tests -> move to right ai.h2o.sparkling packages #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubhava
commented
Apr 1, 2020
| @@ -1,73 +0,0 @@ | |||
| /* | |||
jakubhava
commented
Apr 1, 2020
| @@ -1,69 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
Moved to ai.h2o.sparkling.TestUtils
jakubhava
commented
Apr 1, 2020
| @@ -1,114 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
Moved to ai.h2o.sparkling.TestUtils
mn-mikke
approved these changes
Apr 1, 2020
ml/src/test/scala/ai/h2o/sparkling/ml/PipelinePredictionTest.scala
Outdated
Show resolved
Hide resolved
ml/src/test/scala/ai/h2o/sparkling/ml/algos/H2OKMeansTest.scala
Outdated
Show resolved
Hide resolved
jakubhava
added a commit
that referenced
this pull request
Apr 2, 2020
jakubhava
added a commit
that referenced
this pull request
Apr 2, 2020
jakubhava
added a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last big shuffle with classes, this time with tests classes only:
-> Moving all remaining classes to ai.h2o.sparkling package
-> Putting TestUtils to a single class test utils
-> Extract ml integ tests from core and put them into ml integ tests
-> Few other extractions -> just moving tests to packages where they belong
Wanted to do this change now as we are getting closer to major release as we will switch rel branch to current master soon and avoid possible cherry-pick issues later.
No tests were removed ( edit: except 2 in SupportedRDDTestSuite -> those tests are useless now)