-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare repo for open sourcing #55
Comments
In addition to points above, since tslint is deprecated, I am going to replace it with typescript-eslint as suggested in the official docs. |
Other possible improvements regarding git hooks:
|
Agree @mturoci - I'm fine with conventional commits as long as the |
In order to enforce git hooks for each developer I use husky in combination with lint-staged for linting. It works fine for Problem no. 2 is that for commit linting and markdown linting there exist npm packages, go has native linter as part of an SDK, but the problem is python one. As far as I discovered, python requires pip installing the linter locally. This would introduce |
Adding |
* feat: Deprecated TSlint exchanged for ESlint #55 * fix: Webpack dev server not picking up eslint #55 * feat: Custom ESLint rule for baxed variables #55 * chore: Babel config moved to separate file from package.json #55 * chore: Jest config moved to separate file from package.json #55 * feat: Git hooks - TS compilation, eslint check, related unit tests #55 * chore: VSCode workspace recommended extensions #55 * style: Custom Eslint rule for data-test attributes on component wrappers #55 * fix: Data-test linter #55 * chore: Eslint rule for card names #55 * docs: Contributing.md #55 * docs: CODE_OF_CONDUCT.md #55 * feat: Go lint on precommit #55 * chore: .nvmrc #55 * feat: commitlint #55 * feat: markdownlint #55 * feat: hook for appending issue number to commit msg #55 * fix: make generate #55 * feat: pylint #55 * chore: use /py venv for pylint instead of root one #55 * chore: revert qd.ts rearrangement and turn off corresponding lint rule #55 * chore: remove extra semicolons #55 * chore: syncing package-lock #55 * docs: code review
* feat: flake8 linter instead of pylint * Remove ignore list; set line length to 120 Co-authored-by: Prithvi Prabhu <prithvi@h2o.ai>
A few things that in my opinion should be done before making this repo public:
Jenkins
, it is most of the time busy. I would prefer to have something always ready so we can run our tests on each PR. I have found CI providers with completely free tier for public repos - e.g. Travis CI (there can be others suitable as well of course).tslint
rules to keep consistency since the codebase has a pretty specific style e.g. someVariableB for boxed vars, usingconst
just once and separate variables with,
instead of multiple lines starting withconst
etc.editorconfig
,vs-code
plugin suggestions for this project etc.@lo5 @geomodular Let's use this issue as a starting point for a discussion.
The text was updated successfully, but these errors were encountered: