-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui.table enhancements + redesign #974
Comments
@mturoci here is what I see as the major changes from current
Related UI Table Requests to consider implementing during this component redesign :
|
I can do this as part of this issue by introducing a new
Not sure about this one, do you want to have a tooltip displayed when hovered over row? Can you show an example usecase maybe? The rest of requests seems reasonable for me, thanks @mtanco! |
Oops, I misunderstood. Just a hover effect rather than hover text. The Table component already does this so it is just a design update. |
A few design questions - cc @sandruparo @shanaka-rajitha @shihan007 :
Currently, the grouped mode looks like this: Design team, please let me know what you think. @lo5 here is a proposal for /** Defines cell content to be rendered instead of a simple text. */
interface TableCellType {
/** Renders a progress arc with a percentage value in the middle. */
progress?: ProgressTableCellType
/** Renders an icon. */
icon?: IconTableCellType
/** Renders a one or more chips (badges). */
badge?: BadgeTableCellType
}
/**
* Creates a collection of chips, usually used for rendering state values.
* Note: In case of multiple tags per row, make sure the row values are
* separated by "," within a single cell string.
* E.g. ui.table_row(name='...', cells=['cell1', 'BADGE1,BADGE2']).
*/
export interface BadgeTableCellType {
/** An identifying name for this component. */
name: S
/** Badges to be rendered. */
badges?: Badge[]
}
/**
* Create a badge.
*/
export interface Badge {
/** Text specified within the badge. */
name: S
/** Badge's background color. */
background_color: S
/** Badge's text color. If not specified, black or white will be picked based on correct contrast with background. */
color?: S
} The problem is that we want to support multiple badges per col. The only way to achieve this I could come up with was requiring people to serialize multiple badges within a single string. |
@mturoci for table I have used neutralLight color for header and border did you use the same? |
Yes, that's the one I used. Same as header. The contrast is too low also in the design link posted. |
@mturoci okay then for borders lets go with neutralTeritaryAlt. I will check on icons |
@mturoci okay then for borders lets go with neutralTertiaryAlt. I will check on icons |
@mturoci can we change the placement of sort icon to left if we using the fluent icon? because some column header may have sort and filter dropdown too.. |
Not much of a difference. Here is a wdyt @shihan007 ?
What's the reasoning? As I described in a comment, that would break alignment with data. |
@mturoci For some column headers sort and filter both needed in that case better to place sort icon to left. And each and every column does come with sort feature right? |
But why placing it to the left? What would be the benefit?
Every column can be specified as |
@mturoci I agree with @shihan007 Shihan. I think it's good to place the sorting option left align. anyways most of all the tables in the wave app store needs tables with sorting options. So i dont think it's funky if we can align it nicely to the icon.cause icon should always be there. and telling about the rest of the implementation you did, - it's great Martin. great improvement. But i still see many color difference and spacing issues compared to the design.
Functionality wise i feel you have achieved almost it. But i see look and feel is different still. I just want to know is it possible to update it's theme ? |
This is not true. See the example above for example. Making Besides that, you still didn't provide a reason why left is better than right.
This is a default browser scrollbar for overflowing content. Some browsers support styling it if you mean this, but the browser support is not great at all thus going for the default seems the most reasonable in order to deliver the same experience across multiple browsers.
This one is dynamic based on data and colum types (e.g. in this case progress table cell type makes the whole row bigger). I can set
Yes, these are exactly the colors from the theme. Note that the theme in the screenshot is our current Also note about the first column. This serves as clickable link in our table so that's why the color is different from the other cols. |
---- Why do we need a " Done " column ? if we need to show the user an indication the particular work in the row is done or some states , in UX perspective we have given more suggestions for that. I dont think we need a column like that ?
----- Agree. Sure we can give a personalised configuration to the user to define those , t's setting in the fronted or backend ?
----- i would like to have a scroll defined to us, an unique one based on the design ( those requirements are not major ones, maybe in the future )
---- Please add a minimum height. yes.
-- GREAT ! But i would like to see how this will look when we add our YELLOW theme. Cause Right now it matters to me a lot, we as the design team want to see it's look and feel. for the countless time im requesting on that too. 🤓 🤷♀️🙏 |
I am talking about icons columns in general. The point stands, it does not make sense to make each column sortable.
Wave is backend only that allows you to draw a UI. The config is already in place. The comment was about the sorting icon placement.
Not sure I understood, what definitions do you expect? See my comment about browser support (this means the scrollbar will not be the same across multiple browsers / browser versions so 2 different users might end up with differently looking UI). IMO consistency across browsers (for every user) > multiple variations for scrollbar styles or do you have something else in mind?
I can send you a screenshot with the theme from designs although this will not eliminate the need for changes requested above so I don't see much value in it. |
@mturoci can we change hover bg to neutralLight and do the adjustment on spacing as @sandruparo mentioned. |
Sure, done. By spacing you mean min row height right? |
@mturoci yeah row height. Can't we have set a row height to a fixed value? |
@mturoci table looks great now. you working separately on badges? we have some changes in badges. |
@mturoci looks good now. Thanks for the efforts, i like how it looks now. Can we play with badges colors ? |
Badges colors are configurable - any color can be specified. Any news about group by table designs I wrote about above? |
Yes that also i read @mturoci - grouping is fine but can we have nested groups within another group sets ? Like a tree hierarchy? If this component supports that and if it can has the style we gave we are fine. Well and how about drawing those lines ? hierarchy lines ? |
Table View
Features
Note: don't need the "Action" column equivalent
The text was updated successfully, but these errors were encountered: