Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add vertical alignment to ui.inline #1640

Closed
wants to merge 7 commits into from
Closed

feat: Add vertical alignment to ui.inline #1640

wants to merge 7 commits into from

Conversation

NevilleMthw
Copy link

@NevilleMthw NevilleMthw commented Sep 28, 2022 •
edited
Loading

Hi, this resolves #1535.

Thanks,
Neville

@mturoci
Copy link
Collaborator

mturoci commented Sep 28, 2022

Thanks for the PR @NevilleMthw! Unfortunately, this is not what is needed to be done. I have updated the issue description, so please have a look. I also suggest going through contribution guidelines that describe what needs to be done when adding new props to cards/components.

@NevilleMthw
Copy link
Author

Oh okay. Thanks for the feedback. I will go through the issue again. @mturoci.

mturoci
mturoci requested changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @NevilleMthw! Can you also please include python examples showcasing your feature + update PR description with the screenshots so that we can see how does the feature works in practice.

@NevilleMthw
Copy link
Author

Thanks for the PR @NevilleMthw! Can you also please include python examples showcasing your feature + update PR description with the screenshots so that we can see how does the feature works in practice.

Hi, I will definitely look at trying to create a Python example. Will let you know. Thanks.

@mturoci
Copy link
Collaborator

mturoci commented Oct 19, 2022

Closing due to inactivity.

@mturoci mturoci closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci requested changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow vertical alignment for ui.inline
2 participants
@NevilleMthw @mturoci