Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vertical alignment for ui.inline #1535

Closed
mturoci opened this issue Jul 12, 2022 · 7 comments · Fixed by #1737
Closed

Allow vertical alignment for ui.inline #1535

mturoci opened this issue Jul 12, 2022 · 7 comments · Fixed by #1737
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@mturoci
Copy link
Collaborator

mturoci commented Jul 12, 2022

via @azim-b

Add align attr to ui.inline to allow for vertical alignment. Currently, we center everything by default, which does not suit every case, e.g. displaying 2 choice groups side by side with different choice counts:

image

Implementation notes

  • Add a new align prop to Inline interface with all the possible values that flexbox offers for vertical alignment.
  • Implement the necessary functionality.
  • Add a python example demonstrating the behavior.
@mturoci mturoci added ui Related to UI feature Feature request labels Jul 12, 2022
@mturoci mturoci added the good first issue Contributions welcome! label Sep 12, 2022
@NevilleMthw
Copy link

NevilleMthw commented Sep 26, 2022

Is anyone doing this issue? If not, I could work on it.

@mturoci
Copy link
Collaborator Author

mturoci commented Sep 26, 2022

You can take it @NevilleMthw!

@NevilleMthw
Copy link

Hi @mturoci, is there a separate inline.tsx file to work with or would the changes be in another file?

@mturoci
Copy link
Collaborator Author

mturoci commented Sep 27, 2022

The changes need to be done in form.tsx. Here is the interface and the component. For quicker answers you might also want to join our Discord.

@mturoci
Copy link
Collaborator Author

mturoci commented Oct 13, 2022

This issue is up for grabs again.

@Nicolapps
Copy link
Contributor

I’m working with @sherrychen2, @monal20, and @kitty3190 on a PR for this issue (and also #1645, #495, and #372) as part of a Software Engineering class assignment.

@jding712
Copy link

Hi, my team would like to work on this issue if it is still available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
4 participants