Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow specifying '1' for height in copyable text to fill the remaining space #1879

Merged
merged 7 commits into from Mar 10, 2023

Conversation

marek-mihok
Copy link
Contributor

Updated API description:

export interface CopyableText {
  /** Text to be displayed inside the component. */
  value: S
  /** The text displayed above the textbox. */
  label: S
  /** An identifying name for this component. */
  name?: S
  /** True if the component should allow multi-line text entry. */
  multiline?: B
  /** Custom height in px (e.g. '200px') or use '1' to fill the remaining card space. Requires `multiline` to be set. */
  height?: S
}

Closes #1823

@marek-mihok marek-mihok marked this pull request as ready for review March 8, 2023 13:32
@marek-mihok marek-mihok marked this pull request as draft March 8, 2023 13:33
@marek-mihok marek-mihok marked this pull request as ready for review March 8, 2023 20:11
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok. A couple of changes are needed.

ui/src/copyable_text.tsx Outdated Show resolved Hide resolved
ui/src/copyable_text.tsx Outdated Show resolved Hide resolved
website/widgets/form/copyable_text.md Show resolved Hide resolved
ui/src/copyable_text.tsx Outdated Show resolved Hide resolved
ui/src/copyable_text.tsx Outdated Show resolved Hide resolved
@mturoci mturoci merged commit 119a30e into master Mar 10, 2023
@mturoci mturoci deleted the feat/issue-1823 branch March 10, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying '1' for height in copyable text - fill remaining space
2 participants