Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support percentage height for ui.form components #326 #2004

Closed
wants to merge 5 commits into from

Conversation

marek-mihok
Copy link
Contributor

Screen.Recording.2023-06-02.at.11.02.23.mov

Closes #326

@marek-mihok
Copy link
Contributor Author

marek-mihok commented Jun 2, 2023

@mturoci just fyi, I went through every tour example, tested it in every browser, ran the regression tests and it is working fine, nothing is broken. The support of setting the height in other CSS units is untouched - it works as before. And this implementation works inside responsive layouts too.

@mturoci
Copy link
Collaborator

mturoci commented Jun 2, 2023

Sounds good. Can you elaborate more on what was the problem and why this is the right solution? Did this happen for the table only or were any other components affected as well?

And this implementation works inside responsive layouts too.

I am wondering how this is possible since percentage height requires the parent container to have fixed height specified.

@marek-mihok
Copy link
Contributor Author

marek-mihok commented Jun 20, 2023

I'm closing this PR as setting the height of ui.form components in percentage units is ambiguous - 50% of what? Of the parent ui.inline? Of the ui.form, of the card, of the page or viewport?

We will go with the implementation of setting the height='1' option to fill the all available height for relevant components like we already did for ui.copyable_text or ui.table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table content overlaps when we use height and tooltip together
2 participants