New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement compact
attribute for markup card
#1937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dthiagarajan7! A few small changes necessary.
960cf0a
to
9798310
Compare
@mturoci Thanks for the suggestions! I've just pushed all of the requested revisions and have updated the PR description accordingly. |
Seems like your branch needs to be rebased against the latest master. Please make sure the PR branch only includes changes relevant to the corresponding issue. |
a8a494d
to
9dbe360
Compare
@mturoci I'm so sorry about that! I've trimmed the PR branch to include only the relevant changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking perfect now @dthiagarajan7!
Github Issue
Closes #1922
Description
Added a
compact
attribute to theState
interface ofmarkup.tsx
. Users can now specify whether they want the markup card to include the paddings or not.compact
attribute defaults toFalse
.Succssful Local Testing
Differences between
compact
invocations are depicted above.The code used to produce the markup cards above is included below.