Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement compact attribute for markup card #1922

Closed
bkos opened this issue Apr 11, 2023 · 4 comments · Fixed by #1937
Closed

Implement compact attribute for markup card #1922

bkos opened this issue Apr 11, 2023 · 4 comments · Fixed by #1937
Assignees
@dthiagarajan7
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@bkos
Copy link

bkos commented Apr 11, 2023

There may be too much whitespace in the markup card due to padding. There should be a possibility to remove/decrease it.

Describe the solution you'd like

Implement compact attribute for markup card, similar to #1735.
@bkos bkos added the feature Feature request label Apr 11, 2023
@bkos bkos changed the title Implement compact attribute for markup card Implement compact attribute for markup card Apr 11, 2023
@mturoci mturoci added ui Related to UI good first issue Contributions welcome! labels Apr 12, 2023
@mturoci
Copy link
Collaborator

mturoci commented Apr 13, 2023

Implementation notes since marked as good first issue:

  • Make sure to read https://wave.h2o.ai/docs/contributing/#development-setup.
  • In order to test out the new attribute, once added to the TS definition, make generate from project root is needed to be run - generates Py/R type definitions that you can then use in your python test code.

@dthiagarajan7
Copy link
Contributor

@mturoci Can I please be assigned this issue? I submitted the pull request for issue #1867 and would also love to tackle this as part of my software engineering assignment. Thank you for your consideration.

dthiagarajan7 added a commit to dthiagarajan7/wave that referenced this issue Apr 17, 2023
@dthiagarajan7
feat: Implement compact attribute for markup card h2oai#1922
9798310
@mturoci
Copy link
Collaborator

mturoci commented Apr 17, 2023

Go ahead @dthiagarajan7!

@dthiagarajan7 dthiagarajan7 mentioned this issue Apr 17, 2023
Merged
@dthiagarajan7
Copy link
Contributor

@mturoci Thanks for letting me address this issue! I have submitted the pull request at #1937

dthiagarajan7 added a commit to dthiagarajan7/wave that referenced this issue Apr 17, 2023
@dthiagarajan7
feat: Revisions to compact attribute for markup card h2oai#1922
b2d3144
dthiagarajan7 added a commit to dthiagarajan7/wave that referenced this issue Apr 17, 2023
@dthiagarajan7
feat: Revisions to compact attribute for markup card h2oai#1922
9dbe360
mturoci pushed a commit that referenced this issue Apr 17, 2023
@dthiagarajan7
feat: Add compact attribute for markup card #1922 (#1937)
693f23d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dthiagarajan7 dthiagarajan7

Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement compact attribute for markup card dthiagarajan7/wave
3 participants
@bkos @mturoci @dthiagarajan7