-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add tabs to docs where possible #1785 #2065
Conversation
…niran/wave into documentation-issue-contrib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @oadeniran!
A few minor changes required. I didn't want to duplicate comments for each file so please go through my suggestions and apply them to other files as needed.
When running the Docusaurus docs, I get this warning
[WARNING] Docs markdown link couldn't be resolved: (tutorial-hello.md) in "/Users/martinturoci/go/src/github.com/h2oai/telesync/website/docs/scripts.md" for version current
Hi @mturoci , I just Addressed all points you made in the edits and changes commit |
Why doesn't it run to completion? Btw, the showcase files are still part of this PR, they should not.
There are still comments from me that didn't get answered / resolved. |
I think it doesn't run till completion due to the inadequacies of my pc. The computing power needed for matplotlib is a bit high for the project I think and after a while my wsl just gets stuck on generating a file and never gets past that stage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @oadeniran!
Thanks so much for the approval @mturoci |
Sure, np :) Glad you learned something. |
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.My specific changes:
Closes #1785