Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use absolute URLs in API docs #2078 #2088

Merged
merged 2 commits into from
Jul 31, 2023
Merged

feat: Use absolute URLs in API docs #2078 #2088

merged 2 commits into from
Jul 31, 2023

Conversation

marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Jul 21, 2023 •
edited
Loading

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included
Screen.Recording.2023-07-21.at.16.00.26.mov

Closes #2078
Closes #1667

mturoci
mturoci approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @marek-mihok!

@mturoci mturoci merged commit bf20d4f into main Jul 31, 2023
2 checks passed
@mturoci mturoci deleted the feat/issue-2078 branch July 31, 2023 06:58
mturoci pushed a commit that referenced this pull request Aug 3, 2023
@marek-mihok @mturoci
feat: Use absolute URLs in API docs #2078 (#2088)
f2bc239
marek-mihok added a commit that referenced this pull request Jan 15, 2024
@marek-mihok
feat: Use absolute URLs in API docs #2078 (#2088)
1325c65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken API docs links Use absolute URLs in API section
2 participants
@marek-mihok @mturoci