Texture generation id #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial texturecounter is 0 because texture buffer can't be 0. if id is 0 always create a texture buffer.
Wolf3s
approved these changes
Jan 19, 2024
|
Thanks for the approval :), now just need h4570 to approve it. |
|
Thank you for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Texture generation id #129 by the number of textures created, starting from 1 to avoid always creating a texture buffer.
IDs deleted are saved for later use.
TextureRepository now has a pointer over the texture buffers to remove its texture id and create a new one for the next texture with the same id.
Changing the id is an easy way to create another texture buffer, the bad thing is that it is not destroyed until the vram needs it.
If it is accepted, I recommend that the #174 be accepted first.