Skip to content

Commit

Permalink
kill off plugins.js. Didn't seem to make sense for anyone but me. :) …
Browse files Browse the repository at this point in the history
…Comment on this commit if you lurve it and want it back.
  • Loading branch information
paulirish committed Mar 1, 2011
1 parent c1f064c commit 937c886
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 21 deletions.
1 change: 0 additions & 1 deletion demo/elements.html
Expand Up @@ -504,7 +504,6 @@ <h3>&lt;meter&gt;</h3>


<!-- scripts concatenated and minified via ant build script-->
<script src="../js/plugins.js"></script>
<script src="../js/script.js"></script>
<!-- end concatenated and minified scripts-->

Expand Down
3 changes: 1 addition & 2 deletions demo/tests.html
Expand Up @@ -284,8 +284,7 @@
</script>


<!-- scripts concatenated and minified via ant build script-->
<script src="../js/plugins.js"></script>
<!-- scripts concatenated and minified via ant build script-->s
<script src="../js/script.js"></script>
<!-- end concatenated and minified scripts-->

Expand Down
1 change: 0 additions & 1 deletion index.html
Expand Up @@ -57,7 +57,6 @@


<!-- scripts concatenated and minified via ant build script-->
<script src="js/plugins.js"></script>
<script src="js/script.js"></script>
<!-- end scripts-->

Expand Down
15 changes: 0 additions & 15 deletions js/plugins.js

This file was deleted.

12 changes: 12 additions & 0 deletions js/script.js
Expand Up @@ -23,4 +23,16 @@





// usage: log('inside coolFunc', this, arguments);
// paulirish.com/2009/log-a-lightweight-wrapper-for-consolelog/
function log(){
log.history = log.history || []; // store logs to an array for reference
log.history.push(arguments);
arguments.callee = arguments.callee.caller;
if(this.console) console.log( Array.prototype.slice.call(arguments) );
};
// make it safe to use console.log always
(function(b){function c(){}for(var d="assert,count,debug,dir,dirxml,error,exception,group,groupCollapsed,groupEnd,info,log,markTimeline,profile,profileEnd,time,timeEnd,trace,warn".split(","),a;a=d.pop();)b[a]=b[a]||c})(window.console=window.console||{});

3 changes: 1 addition & 2 deletions test/index.html
Expand Up @@ -8,8 +8,7 @@

<script src="../js/libs/modernizr-1.7.min.js"></script>

<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.4/jquery.min.js"></script>
<script src="../js/plugins.js"></script>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.5.1/jquery.min.js"></script>
<script src="../js/script.js"></script>


Expand Down

15 comments on commit 937c886

@jgv
Copy link

@jgv jgv commented on 937c886 Mar 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like all the plugins in one file. makes total sense in my workflow. why was it disliked?

@paulirish
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of people didn't understand what to do with it.

Or they'd leave it alone but just create script tags for all the plugins they were going to use.

@svnlto
Copy link

@svnlto svnlto commented on 937c886 Mar 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on bringing it back.

@KuraFire
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was “confused” insofar as I thought it just made more sense to have all my plugins at the top of script.js and my custom script below it. Perhaps one thing that could help it would be a comment explaining not just where, but also how the plugin code should be included, with some examples for jQuery plugins, as with such a comment at the top of script.js I don't see any need for bringing back plugins.js anymore.

@joeybaker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on bringing it back. Boilerplate should provide good defaults, no?

@adeelejaz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it made sense to me even though I was a dude that usually threw all his code in one file. Didn't we have something in the wiki about how to use it. Why not just have that wiki entry in the plugins.js file as a comment?

Plus, it makes cursing a lot easier. If the error comes from script.js, you curse yourself. If its from plugins.js, you find out how wrote the damn plugin and curse at them. Its a win-win for me ;)

@roblarsen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but... that's what branches are for...

@walker
Copy link
Contributor

@walker walker commented on 937c886 Mar 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. remove.

@sams
Copy link

@sams sams commented on 937c886 Mar 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for keeping it; it made sense to me first off. A comment in the file should be sufficient. Comments are placed elsewhere concepts harder to grasp so @adeelejaz suggestion make perfect sense. Curse yourself/or them is a chuckle

@zoe-edwards
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t understand what it was at first, but then after reading the docs I really liked the idea and now use it as my standard workflow. +1 for brining it back! Maybe put a comment on the first line explaining its purpose, that’s where everybody will look.

@devinfd
Copy link

@devinfd devinfd commented on 937c886 Mar 4, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on bringing it back.

Sorry Paul

@kahlil
Copy link

@kahlil kahlil commented on 937c886 Mar 4, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on bringing it back

@lynnwallenstein
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on bringing it back.

@MartinMa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. remove.

@paulirish
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's back. a638ad6

Thanks for the feedback, ya'll.

Please sign in to comment.