Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kill off plugins.js. Didn't seem to make sense for anyone but me. :) …
…Comment on this commit if you lurve it and want it back.
- Loading branch information
Showing
6 changed files
with
14 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like all the plugins in one file. makes total sense in my workflow. why was it disliked?
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of people didn't understand what to do with it.
Or they'd leave it alone but just create script tags for all the plugins they were going to use.
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on bringing it back.
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was “confused” insofar as I thought it just made more sense to have all my plugins at the top of script.js and my custom script below it. Perhaps one thing that could help it would be a comment explaining not just where, but also how the plugin code should be included, with some examples for jQuery plugins, as with such a comment at the top of script.js I don't see any need for bringing back plugins.js anymore.
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on bringing it back. Boilerplate should provide good defaults, no?
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it made sense to me even though I was a dude that usually threw all his code in one file. Didn't we have something in the wiki about how to use it. Why not just have that wiki entry in the plugins.js file as a comment?
Plus, it makes cursing a lot easier. If the error comes from script.js, you curse yourself. If its from plugins.js, you find out how wrote the damn plugin and curse at them. Its a win-win for me ;)
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, but... that's what branches are for...
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. remove.
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for keeping it; it made sense to me first off. A comment in the file should be sufficient. Comments are placed elsewhere concepts harder to grasp so @adeelejaz suggestion make perfect sense. Curse yourself/or them is a chuckle
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t understand what it was at first, but then after reading the docs I really liked the idea and now use it as my standard workflow. +1 for brining it back! Maybe put a comment on the first line explaining its purpose, that’s where everybody will look.
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on bringing it back.
Sorry Paul
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on bringing it back
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on bringing it back.
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. remove.
937c886
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's back. a638ad6
Thanks for the feedback, ya'll.