Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(css): use sass #2282

Closed
wants to merge 11 commits into from
Closed

build(css): use sass #2282

wants to merge 11 commits into from

Conversation

vltansky
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This is a draft, for now, relevant to #2274

@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2020

This pull request introduces 1 alert when merging 3f1c7e6 into c3189a6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@vltansky vltansky mentioned this pull request Jun 27, 2020
9 tasks
@vltansky vltansky marked this pull request as ready for review June 27, 2020 07:20
@roblarsen
Copy link
Member

This approach doesn't make sense to me. It's just extra authoring steps. We author main.css in another repo, so exposing it like it should be editable here is confusing. Also, as I said in the main.css repo there isn't any benefit to using sass with these files. I was literally searching for features I could use to justify it and there were none, so I abandoned the idea.

I would potentially be interested in offering this an an option for end users using the create-html5-boilerplate project.

@vltansky vltansky closed this Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants