Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autoprefixer to package.json and integrated autoprefixer into the ... #134

Closed
wants to merge 1 commit into from

Conversation

oleersoy
Copy link
Contributor

@oleersoy oleersoy commented Apr 2, 2015

Thanks for making this site and the HTML5Boilerplate project. Both are brilliant.

It looks like reworkSuit is used only to inline normalize.css css. Consider using rework-npm directly instead.

@alrra
Copy link
Member

alrra commented Apr 2, 2015

@oleersoy Thanks for the pull request and the kind words! :)

It looks like reworkSuit is used only to inline normalize.css css

reworkSuit was used because I was planning a slight redesign of the site and removing some of the code in favor of the equivalent SUIT CSS UI components.

I'm going to close this, as in the current form, I don't see much improvement over the existing code.

@alrra alrra closed this Apr 2, 2015
@oleersoy
Copy link
Contributor Author

oleersoy commented Apr 2, 2015

You do realize that as the build is right now autoprefixer never gets invoked?

@oleersoy
Copy link
Contributor Author

oleersoy commented Apr 2, 2015

BTW - I really like your idea of utilizing the SUIT CSS components

@alrra
Copy link
Member

alrra commented Apr 2, 2015

You do realize that as the build is right now autoprefixer never gets invoked?

@oleersoy You are right! Sorry, totally missed the fact that reworkSuit dropped autoprefixer.

Consider using rework-npm directly instead.

@oleersoy Pull request welcomed!

@alrra alrra reopened this Apr 2, 2015
@alrra alrra closed this in 8a13d77 Apr 2, 2015
@alrra
Copy link
Member

alrra commented Apr 2, 2015

Thanks @oleersoy!

@oleersoy
Copy link
Contributor Author

oleersoy commented Apr 2, 2015

My pleasure :). Thanks again for sharing. I'm looking at integrating css source maps right now as well. Rework has an option for it, and I'm going to test to see if it plays well with csso. I can share the results when I'm done investigating if interested.

alrra pushed a commit that referenced this pull request Apr 2, 2015
Until recently, `rework-suit` also took care of adding the
vendor prefixes, but that doesn't happen anymore as it has
dropped `autoprefixer`.

Ref: suitcss/rework-suit@c4cda10.

Close #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants