Skip to content
This repository has been archived by the owner on Nov 23, 2018. It is now read-only.

Cleanups, fixed demo, updated files, ... #42

Merged
merged 12 commits into from Jun 5, 2011

Conversation

FabianBeiner
Copy link
Contributor

Hello everyone,

I've updated all the files so they're UTF-8, without BOM, using LF instead of CRLF. Furthermore, I've cleaned the files so there is no mixture of tabs and spaces anymore. I also updated the demo to use the latest HTML, fixed a small error in there and updated the the a little bit.

See Commits for "detailed" changes.

Maybe check it out. Sadly, it looks pretty wild in the "Files Changed" tab. ;)

@paulirish
Copy link
Member

Commits like this are always hard to accept due to the fact that they own your entire blame command.. :)

but...

this looks good and there are def a few errors before this helps to correct. :)

the mix of tabs and spaces... normalized to spaces, ya?

@FabianBeiner
Copy link
Contributor Author

I'm not sad if you can't/won't accept it, actually, I get it. ;)

Yes, I've used spaces everywhere, because it looked like the tabs where the minority there.

@paulirish
Copy link
Member

cool cool.

i'll let shi make the call but i'm +1 on this

side note.. i've found that the git gui blame file.ext viewer is best for blame as you can step behind a given commit.

@mathiasbynens
Copy link
Member

We should really specify line endings and stuff in a .gitattributes file. I’ll be glad to add this if you want.

@paulirish
Copy link
Member

mathias, lets. go for it.

mathiasbynens added a commit that referenced this pull request Jun 5, 2011
Cleanups, fixed demo, updated files, ...
@mathiasbynens mathiasbynens merged commit f5651a8 into h5bp:master Jun 5, 2011
@mathiasbynens
Copy link
Member

Okay, before I add the .gitattributes I gotta merge this. Hope that’s okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants