This repository has been archived by the owner on Aug 10, 2020. It is now read-only.
Fix uncorrect links and lang code in translation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those links aren't really incorrect, unquoted attribute values are perfectly valid. Though, it's consistent with the rest of the code style so I'm okay with changing those. If we decide to change it let's do it in all in once, there are plenty other appearances of that in our codebase. |
| @@ -1,6 +1,6 @@ | |||
| <!DOCTYPE html public "i ♥ the web"> | |||
| <!--[if lt IE 9]> <html class="no-js oldie no-fontface" lang="en"> <![endif]--> | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@arthurvr Yeah, it's not really incorrect, but what i actually mean, that such type of link is used only in this translation, so i think it will be good to keep same style here too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.