Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the newest http2 directive #335

Merged
merged 5 commits into from
Jul 23, 2023
Merged

Switch to the newest http2 directive #335

merged 5 commits into from
Jul 23, 2023

Conversation

onemannoplan
Copy link

No description provided.

dependabot bot and others added 4 commits May 24, 2023 23:57
@dependabot @github-actions
Bump dependabot/fetch-metadata from 1.5.0 to 1.5.1
d9b25ec 
Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](dependabot/fetch-metadata@v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@petecooper
Tidy up & uniformity readme (h5bp#333)
1eca13d
@dependabot @github-actions
Bump dependabot/fetch-metadata from 1.5.1 to 1.6.0
b3ca315 
Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](dependabot/fetch-metadata@v1.5.1...v1.6.0)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@onemannoplan
Update .default.conf to include the current http2 directive
cc754d6
@pothi
Copy link

pothi commented Jul 23, 2023

As per https://nginx.org/en/docs/http/ngx_http_v2_module.html , the directive http2 appeared only in Nginx version 1.25.1 (the mainline version) that was released on 13 Jun 2023 (ref: https://nginx.org/en/CHANGES) . So, basically the new format doesn't work on servers running on earlier versions of Nginx.

Backwards compatibility is more important. At least, there should be a comment about where it is safe to use this directive.

@pothi
Copy link

pothi commented Jul 23, 2023

Currently, it will throw nginx: [emerg] unknown directive "http2" when running nginx -t on Nginx version less than 1.25.1.

@LeoColomb LeoColomb changed the title Update .default.conf to include the current http2 directive Switch to newest the current http2 directive Jul 23, 2023
@LeoColomb LeoColomb changed the title Switch to newest the current http2 directive Switch to the newest http2 directive Jul 23, 2023
@LeoColomb LeoColomb changed the base branch from main to feat/h3 July 23, 2023 09:25
@LeoColomb
Copy link
Member

Thanks for this pull request @onemannoplan.
As mentioned by @pothi (thx!) (and despite a missing context/description), this is indeed too early to use with 99% of Nginx installations.

That being, as the work is led by the coming http3 module, we can use your contribution and merge it into feat/h3 branch where we investigate http3 use.

@LeoColomb LeoColomb merged commit 32a8ec2 into h5bp:feat/h3 Jul 23, 2023
3 of 4 checks passed
LeoColomb added a commit that referenced this pull request Nov 23, 2023
@onemannoplan @dependabot
@petecooper @LeoColomb
Switch to the newest http2 directive (#335)
cc98179 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pete Cooper <petecooper@users.noreply.github.com>
Co-authored-by: Léo Colombaro <git@colombaro.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onemannoplan @pothi @LeoColomb @petecooper