-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles: first commit #10
Conversation
Thanks a lot! I've added all your four PRs to a task in our upcoming release. There will hopefully be a release this week, and your PRs will not be part of that since we've done a lot of regression testing already, but are planned for the next one and we should be able to start working on them quite soon. Again, great to see that you're contributing this feature! |
OK, let me know when this is being integrated. Best, |
Any news about it? Best |
We've not been able to start on this yet. Since it involves H5P core it is a bit more involving than your average pull request, but we will take care of this the next time the involved repositories gets a new release! |
Has there been any attempts to test this or create subtitle from file functionality? I just tried to upload this to try it and wasn't able to due to the php file. |
@simondate , we haven't gotten round to this PR and it may not be compatible with the latest version of IV. Which php file are you referring to and what kinds of errors are you getting? |
@xyulex commit has included a .php file called 'language-dropdown.php' which was prevented from being uploaded to my h5p library. |
H5P told me a few months ago that this wasn't going to be integrated since I parse SRT files and they want it to be VTT files. So I'll probably remove those PRs Also, @simondate . That PHP creates a dropdown subtitle menu with the existing uploaded languages. |
It has been determined that subtitle support should be added through the native video player's caption support. This has to do with it supporting different variations of text tracks and accessibility tools. |
Hello,
this is the first commit for the H5P interactive video subtitles integration. Feel free to discuss anything.
I'll be making another one for the H5P WordPress plugin in a few minutes.
Best,
R