Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles: first commit #10

Closed
wants to merge 1 commit into from
Closed

Subtitles: first commit #10

wants to merge 1 commit into from

Conversation

xyulex
Copy link

@xyulex xyulex commented Dec 14, 2015

Hello,

this is the first commit for the H5P interactive video subtitles integration. Feel free to discuss anything.

I'll be making another one for the H5P WordPress plugin in a few minutes.

Best,
R

@falcon-git
Copy link
Member

Thanks a lot! I've added all your four PRs to a task in our upcoming release. There will hopefully be a release this week, and your PRs will not be part of that since we've done a lot of regression testing already, but are planned for the next one and we should be able to start working on them quite soon. Again, great to see that you're contributing this feature!

@xyulex
Copy link
Author

xyulex commented Dec 15, 2015

OK, let me know when this is being integrated.

Best,
R.

@xyulex
Copy link
Author

xyulex commented Feb 5, 2016

Any news about it?

Best

@falcon-git
Copy link
Member

We've not been able to start on this yet. Since it involves H5P core it is a bit more involving than your average pull request, but we will take care of this the next time the involved repositories gets a new release!

@timothyylim timothyylim mentioned this pull request Oct 24, 2016
@simondate
Copy link
Contributor

Has there been any attempts to test this or create subtitle from file functionality? I just tried to upload this to try it and wasn't able to due to the php file.

@timothyylim
Copy link
Contributor

@simondate , we haven't gotten round to this PR and it may not be compatible with the latest version of IV. Which php file are you referring to and what kinds of errors are you getting?

@simondate
Copy link
Contributor

@xyulex commit has included a .php file called 'language-dropdown.php' which was prevented from being uploaded to my h5p library.

@xyulex
Copy link
Author

xyulex commented Nov 29, 2016

H5P told me a few months ago that this wasn't going to be integrated since I parse SRT files and they want it to be VTT files. So I'll probably remove those PRs

Also, @simondate . That PHP creates a dropdown subtitle menu with the existing uploaded languages.

@icc
Copy link
Member

icc commented Apr 24, 2017

It has been determined that subtitle support should be added through the native video player's caption support. This has to do with it supporting different variations of text tracks and accessibility tools.

@icc icc closed this Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants