Fix missing encode_content_links on backup_hvp_activity_task.class #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was unable to backup activity and was also breaking full course back, if user was using hvp activity in course. Patch, fixes above issue.
|
@icc , FYI This is very important! |
|
Indeed, thank you! |
|
This affects the backup despite not having the actual backup steps defined? |
|
You should at least pull in #41 before pulling this one. |
|
Ok, I'm sorry I though this was something that was broken with the current backup support? I can move it into a separate branch. |
|
I think it's fine if #41 is rebased on this, and then merged. The backup feature isn't yet completely finished, but it's fine to merge it as long as the |
|
I agree with @juho-jaakkola |
|
Sorry I was not clear in the beginning (as I thought #41 was already merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was unable to backup activity and was also breaking full course backup,
if user was using hvp activity in course.
Patch, fixes above issue.