Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix check #985

Merged
merged 1 commit into from Jan 30, 2018
Merged

FIX: Fix check #985

merged 1 commit into from Jan 30, 2018

Conversation

larsoner
Copy link
Contributor

On latest NumPy dev I get a lot of these warnings when using h5py:

h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.

This gets rid of them, but I'm not sure if the check should be more or less specific than this, but I think this is the change suggested by the warning message.

@larsoner
Copy link
Contributor Author

... looks like this fix is already part of #926. Feel free to close if it's better to leave it to that PR.

@aragilar aragilar added this to the 2.7.2 milestone Jan 30, 2018
@aragilar
Copy link
Member

I'm merging this, and it should be backported to a 2.7.2 release (my PR is more complicated, so that should only go in a potential 2.8 release).

@aragilar aragilar merged commit 2910768 into h5py:master Jan 30, 2018
@larsoner
Copy link
Contributor Author

Let me know if you need me to do anything for the 2.7.2 backport like open a separate PR

@Erotemic
Copy link

Is there any change of getting this into a release anytime soon? This warning has been appearing for months now.

@larsoner larsoner deleted the fix-check branch March 14, 2018 16:09
@aragilar
Copy link
Member

@Erotemic See https://groups.google.com/forum/#!topic/h5py/liapKtBCmlE, the final release should be coming out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants