-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failures on Appveyor #1225
Conversation
Well, I was right that it's failing to import. Unfortunately, the error message doesn't point to an obvious problem beyond that:
|
Codecov Report
@@ Coverage Diff @@
## master #1225 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 18 18
Lines 2162 2162
=======================================
Hits 1811 1811
Misses 351 351 Continue to review full report at Codecov.
|
OK, I think we're getting somewhere. Older versions of tox automatically downloaded the newest pip & setuptools into newly created environments. Tox 3.10 disabled that by default, which appears to be when our builds started failing. A couple of other projects appear to have been hit by this on Appveyor (tox-dev/tox#1302, tox-dev/tox#1304). I'm not entirely sure what happened, but when tox tried to install h5py with the old version of pip included in the old version of virtualenv on appveyor, it appeared to erroneously decide that h5py was already installed:
Upgrading virtualenv on Appveyor (from 15.0.1 to 16.6.0) appears to fix this, presumably because the new virtualenv bundles a newer pip. If the remaining test jobs succeed, I'll rebase this PR to clean up unwanted changes from debugging. |
More diagnostics in fix_paths.py Diagnostics, robustness in fix_paths.py
88bd5cf
to
b183c74
Compare
Sounds great! |
I've done the rebase. We should obviously wait for the tests to finish, but I think this should do the trick. |
Tests passing. I'll self-merge this, so that Appveyor tests are usable again. |
It looks like it's failing on import, but the real error is being obscured by the test setup.