Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on Appveyor #1225

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Conversation

takluyver
Copy link
Member

It looks like it's failing on import, but the real error is being obscured by the test setup.

@takluyver takluyver mentioned this pull request Jun 3, 2019
@takluyver
Copy link
Member Author

takluyver commented Jun 3, 2019

Well, I was right that it's failing to import. Unfortunately, the error message doesn't point to an obvious problem beyond that:

py36-test-deps run-test: commands[2] | python -c 'import h5py; from h5py.h5py_warnings import H5pyDeprecationWarning'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'h5py'

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #1225 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1225   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files          18       18           
  Lines        2162     2162           
=======================================
  Hits         1811     1811           
  Misses        351      351

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428166a...b183c74. Read the comment docs.

@takluyver
Copy link
Member Author

OK, I think we're getting somewhere. Older versions of tox automatically downloaded the newest pip & setuptools into newly created environments. Tox 3.10 disabled that by default, which appears to be when our builds started failing. A couple of other projects appear to have been hit by this on Appveyor (tox-dev/tox#1302, tox-dev/tox#1304).

I'm not entirely sure what happened, but when tox tried to install h5py with the old version of pip included in the old version of virtualenv on appveyor, it appeared to erroneously decide that h5py was already installed:

[2916] C:\projects\h5py$ 'C:\projects\h5py\.tox\py36-test-deps\Scripts\python.EXE' -m pip install --exists-action w '.tox\.tmp\package\1\h5py-2.9.0.post0.zip'
Processing c:\projects\h5py\.tox\.tmp\package\1\h5py-2.9.0.post0.zip
  Requirement already satisfied (use --upgrade to upgrade): h5py==2.9.0.post0 from file:///C:/projects/h5py/.tox/.tmp/package/1/h5py-2.9.0.post0.zip in c:\projects\h5py

Upgrading virtualenv on Appveyor (from 15.0.1 to 16.6.0) appears to fix this, presumably because the new virtualenv bundles a newer pip.

If the remaining test jobs succeed, I'll rebase this PR to clean up unwanted changes from debugging.

@scopatz
Copy link
Member

scopatz commented Jun 3, 2019

Sounds great!

@takluyver takluyver changed the title WIP: Try to debug appveyor failures Fix test failures on Appveyor Jun 3, 2019
@takluyver takluyver added this to the 2.10 milestone Jun 3, 2019
@takluyver
Copy link
Member Author

I've done the rebase. We should obviously wait for the tests to finish, but I think this should do the trick.

@takluyver
Copy link
Member Author

Tests passing. I'll self-merge this, so that Appveyor tests are usable again.

@takluyver takluyver merged commit c0c0b12 into h5py:master Jun 3, 2019
@takluyver takluyver deleted the appveyor-failure-dbg branch June 3, 2019 20:51
florisla added a commit to florisla/bump2version that referenced this pull request Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants