Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_build.py: avoid absolute path #1803

Closed
wants to merge 1 commit into from
Closed

Conversation

Mingli-Yu
Copy link

Prevent absolute path from ending up in the egg-info SOURCES.txt.

Signed-off-by: Mingli Yu mingli.yu@windriver.com

Prevent absolute path from ending up in the egg-info SOURCES.txt.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
@Mingli-Yu
Copy link
Author

This PULL request used to fix #1802

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1803 (3f10233) into master (7766ca7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1803   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files          17       17           
  Lines        2275     2275           
=======================================
  Hits         2014     2014           
  Misses        261      261           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7766ca7...3f10233. Read the comment docs.

@takluyver
Copy link
Member

I think the idea of using __file__ like that is that it can work regardless of what the cwd is when you run it. But I'm not sure if that's actually something we need to worry about, or if we should assume that it has to be built from the directory containing setup.py anyway.

I also don't know if SOURCES.txt actually matters for anything. The .egg-infodirectory is something non-standard that setuptools produces, and I don't think SOURCES.txt is part of any official standard.

@takluyver
Copy link
Member

Closed as we haven't really established that there's a problem to solve - see #1802.

@takluyver takluyver closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants