Deprecate setting default_file_mode, only allow setting to 'r' #1839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 2 of removing the config option added to ease the transition from 2.x to 3.x:
We added the option (and indicated that the default would change) in 2.10 (released September 2019). The default changed to 'r' in 3.0 (October 2020). The warning for setting the default to modes other than 'r' was added in 3.2 (March 2021).
I'm provisionally marking this for 3.3, but I'm happy to leave it longer if people prefer. We could also start error-ing on modes other than r but leave the warning on setting the default to r for later.