-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme: replace google group with the HDF forum #1926
Conversation
Thanks @FFY00 ! The tests are failing because you need to add your self to the contributors file, see guidance at https://dev.azure.com/h5pyappveyor/h5py/_build/results?buildId=1112&view=logs&j=c4851542-858c-5aa0-9714-b02cde6c1394&t=230ae624-38df-5377-5338-7a322a9283fe&l=424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modulo getting CI to pass.
The Google group is locked and the discussions have moved to the HDF forum. https://groups.google.com/g/h5py/c/9Eoz3vqlPZs Signed-off-by: Filipe Laíns <lains@riseup.net>
50f46b3
to
bdf12ea
Compare
Codecov Report
@@ Coverage Diff @@
## master #1926 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 17 17
Lines 2306 2306
=======================================
Hits 2040 2040
Misses 266 266 Continue to review full report at Codecov.
|
It looks like it's now complaining that your Gmail address isn't in |
Uh, it seems that Github changed the email configurations and nuked the public email config as that is now configured in the profile page. I had not noticed this and updated the email shown in my profile to the one that should be there anyway, the one I specified in the authors file. Would it be possible to manually re-trigger the CI? |
Closing & reopening the PR should do it. 🤞 |
Nope, it still seems to find the gmail address. 😕 I'll try to look into re-ver and figure out what it's doing. |
OK, I've figured it out. It is getting emails from the commit log, but the commit that gets tested is a merge commit generated on Github (as if the PR was merged with master). That commit used your gmail address, even after you changed the publicly visible address on your profile. Perhaps it's the primary address on your account? Anyway, that should mean that if I merge the PR, the real merge commit will be associated with me, and it should be happy... 🤞 |
Yup, it worked. Thanks for the PR 😄 |
I made an issue on rever for an option to avoid this problem: regro/rever#250 |
The Google group is locked and the discussions have moved to the HDF
forum.
https://groups.google.com/g/h5py/c/9Eoz3vqlPZs
Signed-off-by: Filipe Laíns lains@riseup.net