Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: replace google group with the HDF forum #1926

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

FFY00
Copy link
Contributor

@FFY00 FFY00 commented Jul 7, 2021

The Google group is locked and the discussions have moved to the HDF
forum.

https://groups.google.com/g/h5py/c/9Eoz3vqlPZs

Signed-off-by: Filipe Laíns lains@riseup.net

@tacaswell
Copy link
Member

Thanks @FFY00 ! The tests are failing because you need to add your self to the contributors file, see guidance at https://dev.azure.com/h5pyappveyor/h5py/_build/results?buildId=1112&view=logs&j=c4851542-858c-5aa0-9714-b02cde6c1394&t=230ae624-38df-5377-5338-7a322a9283fe&l=424

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo getting CI to pass.

The Google group is locked and the discussions have moved to the HDF
forum.

https://groups.google.com/g/h5py/c/9Eoz3vqlPZs

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 force-pushed the readme-move-ggroup-to-forum branch from 50f46b3 to bdf12ea Compare July 7, 2021 20:47
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #1926 (bdf12ea) into master (24d5389) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1926   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          17       17           
  Lines        2306     2306           
=======================================
  Hits         2040     2040           
  Misses        266      266           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d5389...bdf12ea. Read the comment docs.

@takluyver
Copy link
Member

It looks like it's now complaining that your Gmail address isn't in .authors.yml. I can only guess it's getting that from your Github profile. Sorry about this - I'm continually a bit baffled by the authors check. 😕

@FFY00
Copy link
Contributor Author

FFY00 commented Jul 7, 2021

Uh, it seems that Github changed the email configurations and nuked the public email config as that is now configured in the profile page. I had not noticed this and updated the email shown in my profile to the one that should be there anyway, the one I specified in the authors file. Would it be possible to manually re-trigger the CI?

@takluyver
Copy link
Member

Closing & reopening the PR should do it. 🤞

@takluyver takluyver closed this Jul 8, 2021
@takluyver takluyver reopened this Jul 8, 2021
@takluyver
Copy link
Member

Nope, it still seems to find the gmail address. 😕 I'll try to look into re-ver and figure out what it's doing.

@takluyver takluyver added this to the 3.4 milestone Jul 8, 2021
@takluyver
Copy link
Member

OK, I've figured it out. It is getting emails from the commit log, but the commit that gets tested is a merge commit generated on Github (as if the PR was merged with master). That commit used your gmail address, even after you changed the publicly visible address on your profile. Perhaps it's the primary address on your account?

Anyway, that should mean that if I merge the PR, the real merge commit will be associated with me, and it should be happy... 🤞

@takluyver takluyver merged commit a6c6590 into h5py:master Jul 8, 2021
@takluyver
Copy link
Member

Yup, it worked. Thanks for the PR 😄

@takluyver
Copy link
Member

I made an issue on rever for an option to avoid this problem: regro/rever#250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants