-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in hard link example #1937
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 17 17
Lines 2306 2306
=======================================
Hits 2040 2040
Misses 266 266 Continue to review full report at Codecov.
|
Thanks! Can you please also add your self to https://github.com/h5py/h5py/blob/master/.authors.yml ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modulo getting the tests to pass.
Added myself to authors. It looked like the build based on that previous one line change had an issue -- was it mine? |
Sorry about this; the tool that's checking the authors information did not anticipate people having no email address in git. I'm trying to get it fixed: regro/rever#251 |
Aha. That's funny, because initially there was an email in there (but not really a valid one, just fdouglis@somelocalmachine) and github bounced it because it said "Do you really want to expose an email address in your commit?" --- apparently some setting in my profile. So I set it to empty, and github's push was happy, but the post-processing was not. Then of course you asked me to add my info to the author page, so the exposure was moot anyway. |
If we can get rever fixed to allow this, you will be able to remove your email address from the |
We've got rid of the authors listing thing entirely, which cleared the way to merge this. You can still see the list of contributors on Github (https://github.com/h5py/h5py/graphs/contributors ), or with |
This is a trivial change per my comment in the forum. It looks like it referenced the file
f
rather than thegroup
object.