Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in hard link example #1937

Merged
merged 2 commits into from
Aug 12, 2021
Merged

fix typo in hard link example #1937

merged 2 commits into from
Aug 12, 2021

Conversation

fdouglis
Copy link

@fdouglis fdouglis commented Aug 4, 2021

This is a trivial change per my comment in the forum. It looks like it referenced the file f rather than the group object.

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #1937 (c23f5dd) into master (cd57b9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1937   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          17       17           
  Lines        2306     2306           
=======================================
  Hits         2040     2040           
  Misses        266      266           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd57b9c...c23f5dd. Read the comment docs.

@tacaswell
Copy link
Member

Thanks! Can you please also add your self to https://github.com/h5py/h5py/blob/master/.authors.yml ?

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo getting the tests to pass.

@fdouglis
Copy link
Author

fdouglis commented Aug 4, 2021

Added myself to authors. It looked like the build based on that previous one line change had an issue -- was it mine?

@takluyver
Copy link
Member

Sorry about this; the tool that's checking the authors information did not anticipate people having no email address in git. I'm trying to get it fixed: regro/rever#251

@fdouglis
Copy link
Author

fdouglis commented Aug 5, 2021

Aha. That's funny, because initially there was an email in there (but not really a valid one, just fdouglis@somelocalmachine) and github bounced it because it said "Do you really want to expose an email address in your commit?" --- apparently some setting in my profile. So I set it to empty, and github's push was happy, but the post-processing was not. Then of course you asked me to add my info to the author page, so the exposure was moot anyway.

@takluyver
Copy link
Member

If we can get rever fixed to allow this, you will be able to remove your email address from the .authors.yml file again (and you can amend the commit and force push if you don't want it to be there in Git history).

@takluyver takluyver mentioned this pull request Aug 11, 2021
@takluyver takluyver merged commit cc17661 into h5py:master Aug 12, 2021
@takluyver takluyver added this to the 3.4 milestone Aug 12, 2021
@takluyver
Copy link
Member

We've got rid of the authors listing thing entirely, which cleared the way to merge this. You can still see the list of contributors on Github (https://github.com/h5py/h5py/graphs/contributors ), or with git shortlog -s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants